You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/18 18:53:03 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

ijuma commented on a change in pull request #11067:
URL: https://github.com/apache/kafka/pull/11067#discussion_r671882760



##########
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##########
@@ -389,6 +389,9 @@ class BrokerServer(
       // a potentially lengthy recovery-from-unclean-shutdown operation here, if required.
       metadataListener.startPublishing(metadataPublisher).get()
 
+      // Log static broker configurations.
+      new KafkaConfig(config.originals(), true)

Review comment:
       A couple of questions:
   1. Where are we logging this for the zk case?
   2. Can we expose a method in `KafkaConfig` to write the configs to a logger or something? Seems a bit cleaner than this approach.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org