You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/20 00:32:25 UTC
[GitHub] [airflow] AmarEL opened a new pull request #13191: Fix disable login option behavior
AmarEL opened a new pull request #13191:
URL: https://github.com/apache/airflow/pull/13191
When set the AUTH_ROLE_PUBLIC entry in the webserver_config.py, the app needs to be able to read the value for this entry and this pull request fix the way to access this entry value
closes: #13142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13191: Fix disable login option behavior
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13191:
URL: https://github.com/apache/airflow/pull/13191#issuecomment-751595519
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13191: Fix disable login option behavior
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13191:
URL: https://github.com/apache/airflow/pull/13191
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13191: Fix disable login option behavior
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13191:
URL: https://github.com/apache/airflow/pull/13191#issuecomment-748547089
@AmarEL Could you please add tests to check these configurations to prevent regressions and documentation on how to disable log-in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AmarEL edited a comment on pull request #13191: Fix disable login option behavior
Posted by GitBox <gi...@apache.org>.
AmarEL edited a comment on pull request #13191:
URL: https://github.com/apache/airflow/pull/13191#issuecomment-749089831
> @AmarEL Could you please add tests to prevent regressions and documentation on how to disable log-in?
Done.
Do you have any other suggestions @mik-laj ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AmarEL commented on pull request #13191: Fix disable login option behavior
Posted by GitBox <gi...@apache.org>.
AmarEL commented on pull request #13191:
URL: https://github.com/apache/airflow/pull/13191#issuecomment-749110707
> @AmarEL Could you please add tests to prevent regressions and documentation on how to disable log-in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #13191: Fix disable login option behavior
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #13191:
URL: https://github.com/apache/airflow/pull/13191#issuecomment-748547089
@AmarEL Could you please add tests to prevent regressions and documentation on how to disable log-in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AmarEL closed pull request #13191: Fix disable login option behavior
Posted by GitBox <gi...@apache.org>.
AmarEL closed pull request #13191:
URL: https://github.com/apache/airflow/pull/13191
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AmarEL commented on pull request #13191: Fix disable login option behavior
Posted by GitBox <gi...@apache.org>.
AmarEL commented on pull request #13191:
URL: https://github.com/apache/airflow/pull/13191#issuecomment-749089831
> @AmarEL Could you please add tests to prevent regressions and documentation on how to disable log-in?
Done.
Do you have any other suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org