[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #184: use `pekko:` in urls and fix other branding issues

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on code in PR #184:
URL: https://github.com/apache/incubator-pekko/pull/184#discussion_r1107219530


##########
docs/src/main/paradox/testing.md:
##########
@@ -310,7 +310,7 @@ wall time, not CPU time or system time.
 @@@ div { .group-scala }
 
 Ray Roestenburg has written a great article on using the TestKit:
-[https://web.archive.org/web/20180114133958/http://roestenburg.agilesquad.com/2011/02/unit-testing-akka-actors-with-testkit_12.html](https://web.archive.org/web/20180114133958/http://roestenburg.agilesquad.com/2011/02/unit-testing-akka-actors-with-testkit_12.html).
+[https://web.archive.org/web/20180114133958/http://roestenburg.agilesquad.com/2011/02/unit-testing-pekko-actors-with-testkit_12.html](https://web.archive.org/web/20180114133958/http://roestenburg.agilesquad.com/2011/02/unit-testing-pekko-actors-with-testkit_12.html).

Review Comment:
   ```suggestion
   [https://web.archive.org/web/20180114133958/http://roestenburg.agilesquad.com/2011/02/unit-testing-akka-actors-with-testkit_12.html](https://web.archive.org/web/20180114133958/http://roestenburg.agilesquad.com/2011/02/unit-testing-akka-actors-with-testkit_12.html).
   ```



##########
actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala:
##########
@@ -484,7 +484,7 @@ class Serialization(val system: ExtendedActorSystem) extends Extension {
   // include "com.google.protobuf.GeneratedMessage" = proto in configured serialization-bindings.
   private def checkGoogleProtobuf(className: String): Boolean = checkClass("com.google.protobuf", className)
 
-  // akka-protobuf is now not a dependency of remote so only load if user has explicitly added it
+  // pekko-tobuf is now not a dependency of remote so only load if user has explicitly added it

Review Comment:
   ```suggestion
     // pekko-protobuf is now not a dependency of remote so only load if user has explicitly added it
   ```



##########
scripts/link-validator.conf:
##########
@@ -39,7 +39,7 @@ site-link-validator {
   ]
 
   ignore-missing-local-files-regex = ""
-  // e.g. "^api/alpakka/snapshot/pekko/stream/alpakka/googlecloud/storage/impl/Formats.*"
+  // e.g. "^api/connectors/snapshot/pekko/stream/connectors/googlecloud/storage/impl/Formats.*"

Review Comment:
   Is that really correct? But maybe doesn't matter right now...



##########
scripts/release-train-issue-template.md:
##########
@@ -19,7 +19,7 @@ Release Akka $VERSION$
 ### Check availability
 
 - [ ] Check [reference](https://pekko.apache.org/docs/pekko/$VERSION$/) documentation
-- [ ] Check the release on [Maven central](https://repo1.maven.org/maven2/com/typesafe/akka/akka-actor_2.13/$VERSION$/)
+- [ ] Check the release on [Maven central](https://repo1.maven.org/maven2/com/typesafe/akka/pekko-actor_2.13/$VERSION$/)

Review Comment:
   ```suggestion
   - [ ] Check the release on [Maven central](https://repo1.maven.org/maven2/org/apache/pekko/pekko-actor_2.13/$VERSION$/)
   ```



##########
docs/src/main/paradox/project/migration-guides.md:
##########
@@ -11,7 +11,7 @@ please [migrate to Akka 2.6](https://doc.akka.io/docs/akka/current/project/migra
 This is just stub documentation. It will be improved.
 
 * for Pekko jar dependencies, the groupId is "org.apache.pekko" instead of "com.typesafe.akka"
-* the jar names start with "pekko" instead of "akka" - e.g. pekko-actor_2.13.jar instead of akka-actor_2.13.jar 
+* the jar names start with "pekko" instead of "akka" - e.g. pekko-actor_2.13.jar instead of pekko-actor_2.13.jar 

Review Comment:
   ```suggestion
   * the jar names start with "pekko" instead of "akka" - e.g. pekko-actor_2.13.jar instead of akka-actor_2.13.jar 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org