You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/07/18 07:57:59 UTC

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #11259: Proofread Oracle SELECT Hierarchical Query and GroupBy Clause

ThanoshanMV commented on pull request #11259:
URL: https://github.com/apache/shardingsphere/pull/11259#issuecomment-882016203


   Hi @tristaZero, 
   
   @wgy8283335 reviewed this PR. We need to get insight from you whether is it okay on creating a new constructor for `ColumnOrderByItem`, `ExpressionOrderByItem` and `IndexOrderByItem` without having `OrderDirection` as a parameter. If it's not recommended, I'll remove it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org