You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "denis-chudov (via GitHub)" <gi...@apache.org> on 2023/06/26 08:28:42 UTC

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2224: IGNITE-17770 ItIgniteNodeRestartTest.testCfgGap is flaky

denis-chudov commented on code in PR #2224:
URL: https://github.com/apache/ignite-3/pull/2224#discussion_r1241817705


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -446,14 +446,16 @@ private <R> CompletableFuture<R> enlistWithRetry(
                                         requestFunction.apply(tx.commitPartition(), primaryReplicaAndTerm.get2())
                                 );
                             } catch (PrimaryReplicaMissException e) {
-                                throw new TransactionException(e);
+                                throw new TransactionException(INTERNAL_ERR, e);

Review Comment:
   I did it just because the constructor with only Throwable as argument is deprecated. Let's remove the error code and rework this later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org