You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by NorthNick <gi...@git.apache.org> on 2016/01/20 10:47:09 UTC
[GitHub] couchdb-snappy pull request: Support snappy Windows compilation
GitHub user NorthNick opened a pull request:
https://github.com/apache/couchdb-snappy/pull/5
Support snappy Windows compilation
Windows does not understand ssize_t, so this change brings in the relevant header file. A more autoconf-y way of doing it might be to put the change into a new config.h file and set the HAVE_CONFIG_H flag. That would maintain closer compatibility with the original snappy code, but be a bit more complex in rebar configuration.
Bringing in BaseTsd.h generates quite a lot of compiler cruft. We might just directly typedef ssize_t to something, but that runs the risk of errors in the future if the right thing to typedef it to changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NorthNick/couchdb-snappy master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-snappy/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit e9c914f19f404737ba1bd76381573c4a573258f0
Author: NickNorth <no...@gmail.com>
Date: 2016-01-20T09:37:48Z
Support Windows compilation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-snappy pull request: Support snappy Windows compilation
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/5#issuecomment-173867499
+1. You can rebase it against master for the green build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-snappy pull request: Support snappy Windows compilation
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/5#issuecomment-173865606
It seems R14 no longer work'able on travis ):
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-snappy pull request: Support snappy Windows compilation
Posted by NorthNick <gi...@git.apache.org>.
Github user NorthNick commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/5#issuecomment-174189908
Thanks for the Travis update. The build is now green after rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-snappy pull request: Support snappy Windows compilation
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/5#issuecomment-173867661
No, actually we no longer support R14 to care about, but the issue is for travis rebar, it's not ours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-snappy pull request: Support snappy Windows compilation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-snappy/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-snappy pull request: Support snappy Windows compilation
Posted by NorthNick <gi...@git.apache.org>.
Github user NorthNick commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/5#issuecomment-173867039
I noticed that, but it seems like a general Erlang problem rather than anything to do with this change. Or have I misunderstood the error messages?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---