You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Sxnan (via GitHub)" <gi...@apache.org> on 2024/09/10 04:27:49 UTC

[PR] [FLINK-34079][config] Refactor callers that use deprecated get/setXXX [flink]

Sxnan opened a new pull request, #25301:
URL: https://github.com/apache/flink/pull/25301

   ## What is the purpose of the change
   
   Refactor all callers that use the deprecated `public Xxx getXxx(String key)` and `public void setXxx(String key, Xxx value)`.
   
   
   ## Brief change log
   
   - Refactor callers that use deprecated get/setXXX
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34168][config] Refactor callers that use deprecated get/setXXX [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25301:
URL: https://github.com/apache/flink/pull/25301#issuecomment-2339593438

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ef57966dd2302827f76d8982de53dee975838336",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ef57966dd2302827f76d8982de53dee975838336",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ef57966dd2302827f76d8982de53dee975838336 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34168][config] Refactor callers that use deprecated get/setXXX [flink]

Posted by "Sxnan (via GitHub)" <gi...@apache.org>.
Sxnan commented on PR #25301:
URL: https://github.com/apache/flink/pull/25301#issuecomment-2343557771

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34168][config] Refactor callers that use deprecated get/setXXX [flink]

Posted by "Sxnan (via GitHub)" <gi...@apache.org>.
Sxnan commented on PR #25301:
URL: https://github.com/apache/flink/pull/25301#issuecomment-2342528804

   @1996fanrui It is indeed conflicted with #25302. I updated the PR accordingly. PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34168][config] Refactor callers that use deprecated get/setXXX [flink]

Posted by "Sxnan (via GitHub)" <gi...@apache.org>.
Sxnan merged PR #25301:
URL: https://github.com/apache/flink/pull/25301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34168][config] Refactor callers that use deprecated get/setXXX [flink]

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #25301:
URL: https://github.com/apache/flink/pull/25301#issuecomment-2342483064

   It seems `flink-core/src/test/java/org/apache/flink/configuration/ConfigurationTest.java` conflicts with master branch.
   
   Also, could we review this PR after https://github.com/apache/flink/pull/25301 is merged? I'm afraid they conflicts as well. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org