[GitHub] jena pull request #461: JENA-1591: use boolean value in if expression

[kinow <gi...@git.apache.org>]

GitHub user kinow opened a pull request:

    https://github.com/apache/jena/pull/461

    JENA-1591: use boolean value in if expression

    Another one found in Eclipse while I was reading some other code for UUID's. The value returned from the `Set` object will be a `boolean`, so the `== null` won't ever eval to true.
    
    This pull request uses the expression `! x` as that's what I thought we actually wanted to test. But happy to update it if I made the wrong assumption.
    
    Could not find an easy way to generate a unit test, but if there's some simple approach, please let me know and I will update the pull request.
    
    Thanks
    Bruno

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kinow/jena JENA-1591

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #461
    
----
commit 76a02057a4f6e43bb1e237bf4caca17c9b395435
Author: Bruno P. Kinoshita <ki...@...>
Date:   2018-08-11T12:59:46Z

    JENA-1591: use boolean value in if expression

----


---

[GitHub] jena issue #461: JENA-1591: use boolean value in if expression

[kinow <gi...@git.apache.org>]

Github user kinow commented on the issue:

    https://github.com/apache/jena/pull/461
  
    Rebased and amended to use my apache e-mail in the commits. Merging. Thanks!!!


---

[GitHub] jena pull request #461: JENA-1591: use boolean value in if expression

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/461


---