You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "DL1231 (via GitHub)" <gi...@apache.org> on 2023/07/03 12:52:08 UTC
[GitHub] [kafka] DL1231 commented on a diff in pull request #13950: KAFKA-15140: Improve TopicCommandIntegrationTest to be less flaky
DL1231 commented on code in PR #13950:
URL: https://github.com/apache/kafka/pull/13950#discussion_r1250844730
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -172,13 +172,11 @@ class TopicCommandIntegrationTest extends KafkaServerTestHarness with Logging wi
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testCreateWhenAlreadyExists(quorum: String): Unit = {
- val numPartitions = 1
-
// create the topic
+ TestUtils.createTopicWithAdmin(adminClient, testTopicName, brokers, 1, 1)
+
val createOpts = new TopicCommandOptions(
Array("--partitions", numPartitions.toString, "--replication-factor", "1", "--topic", testTopicName))
- createAndWaitTopic(createOpts)
Review Comment:
I'm sorry, I misunderstood your meaning in JIRA. I have already reverted back the changes to createAndWaitTopic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org