You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/05/04 15:35:36 UTC
[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #6356: Log load bean exception
JoaoJandre commented on code in PR #6356:
URL: https://github.com/apache/cloudstack/pull/6356#discussion_r864984954
##########
utils/src/main/java/com/cloud/utils/component/ComponentContext.java:
##########
@@ -72,8 +72,14 @@ public static void initComponentsLifeCycle() {
Map<String, ComponentMethodInterceptable> interceptableComponents = getApplicationContext().getBeansOfType(ComponentMethodInterceptable.class);
for (Map.Entry<String, ComponentMethodInterceptable> entry : interceptableComponents.entrySet()) {
- Object bean = getTargetObject(entry.getValue());
- beanFactory.configureBean(bean, entry.getKey());
+ try {
+ Object bean = getTargetObject(entry.getValue());
+ beanFactory.configureBean(bean, entry.getKey());
+ } catch (Throwable e){
Review Comment:
I did some testing and the exceptions thrown really are all `BeansException`, I'll change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org