You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/11/19 22:05:09 UTC

Review Request 69399: ATLAS-2975: updated Hive hook to avoid duplicate column-lineage entities; also updated Atlas server to skip duplicate column-lineage entities

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69399/
-----------------------------------------------------------

Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Mehul Parikh, Nixon Rodrigues, Ramesh Mani, and Sarath Subramanian.


Bugs: ATLAS-2975
    https://issues.apache.org/jira/browse/ATLAS-2975


Repository: atlas


Description
-------

- updated Hive hook to avoid duplicate column-lineage entity for output columns
- update Atlas server pre-processing of notification message to purge duplicate column-lineage entities


Diffs
-----

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java 6d2517c26 
  webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java da1be9e46 


Diff: https://reviews.apache.org/r/69399/diff/1/


Testing
-------

- verified that Hive hook and Atlas server avoid duplicate column-lineage entities, by exercising the repro scenario detailed in the JIRA
- pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/844/


Thanks,

Madhan Neethiraj


Re: Review Request 69399: ATLAS-2975: updated Hive hook to avoid duplicate column-lineage entities; also updated Atlas server to skip duplicate column-lineage entities

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69399/#review210689
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Nov. 19, 2018, 2:05 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69399/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2018, 2:05 p.m.)
> 
> 
> Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Mehul Parikh, Nixon Rodrigues, Ramesh Mani, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2975
>     https://issues.apache.org/jira/browse/ATLAS-2975
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - updated Hive hook to avoid duplicate column-lineage entity for output columns
> - update Atlas server pre-processing of notification message to purge duplicate column-lineage entities
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java 6d2517c26 
>   webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java da1be9e46 
> 
> 
> Diff: https://reviews.apache.org/r/69399/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that Hive hook and Atlas server avoid duplicate column-lineage entities, by exercising the repro scenario detailed in the JIRA
> - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/844/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>