You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2023/06/05 11:30:41 UTC

[GitHub] [kafka] yashmayya opened a new pull request, #13808: MINOR: Re-introduce Transformation import to fix TransformationChain Javadoc

yashmayya opened a new pull request, #13808:
URL: https://github.com/apache/kafka/pull/13808

   - The `TransformationChain` Javadoc has a reference to the `Transformation` class
   - The import was removed (likely accidentally) in https://github.com/apache/kafka/pull/13184/files#diff-be87d8114b5870f9b881cf8c0e6b110951aa990a7d2ad74c886f3a2adb2350db
   - It doesn't break the build since we don't generate public Javadocs for this class, but it does affect things like code navigation in IDEs.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #13808: MINOR: Re-introduce Transformation import to fix TransformationChain Javadoc

Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #13808:
URL: https://github.com/apache/kafka/pull/13808#issuecomment-1576833452

   Not sure what's going on with Jenkins but I've verified locally that this builds correctly and fixes the relevant Javadocs linking issue. Merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] yashmayya commented on pull request #13808: MINOR: Re-introduce Transformation import to fix TransformationChain Javadoc

Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #13808:
URL: https://github.com/apache/kafka/pull/13808#issuecomment-1576846060

   Thanks Chris! Yeah, the Jenkins thing is odd - no build has been triggered for this merged commit on `trunk` either. Do we need to raise an [Apache INFRA Jira](https://issues.apache.org/jira/projects/INFRA/) ticket?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante merged pull request #13808: MINOR: Re-introduce Transformation import to fix TransformationChain Javadoc

Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante merged PR #13808:
URL: https://github.com/apache/kafka/pull/13808


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #13808: MINOR: Re-introduce Transformation import to fix TransformationChain Javadoc

Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #13808:
URL: https://github.com/apache/kafka/pull/13808#issuecomment-1576857909

   Wild guess with little backing knowledge: I wonder if the queue is just full. It looks like there's two open PRs right now that don't have finished CI runs; the one that was opened earlier is currently running, and the most-recently-opened one doesn't have anything (yet).
   
   If we can rule that out and this starts significantly affecting us, then yeah, an infra ticket is probably warranted 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org