[jira] [Commented] (GEODE-4377) Don't catch encoding exceptions in OperationHandlers

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361523#comment-16361523 ] 

ASF subversion and git services commented on GEODE-4377:
--------------------------------------------------------

Commit 6e255ecf1fddde7440079d148fdcfca5c6bcbf5b in geode's branch refs/heads/feature/GEODE-4377 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6e255ec ]

GEODE-4377: Don't catch encoding exceptions in OperationHandlers

This adds DecodingException and moves the handling of both
EncodingException and DecodingException to ProtobufOpsProcessor's
processOperation() method.


> Don't catch encoding exceptions in OperationHandlers
> ----------------------------------------------------
>
>                 Key: GEODE-4377
>                 URL: https://issues.apache.org/jira/browse/GEODE-4377
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Galen O'Sullivan
>            Priority: Major
>
> In the protobuf protocol, we are currently catching EncodingException due to values that we can't deserialize or result values that we can't serialize.
> Encoding and decoding exceptions should be handled differently, so clients can tell if a value was present but could not be serialized.
> Encoding and decoding errors should be handled consistently across operation handlers.
> Probably we could throw Encoding or Decoding exceptions and handle them at a higher level than the individual op handler.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)