You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/08 09:46:20 UTC

[GitHub] [shardingsphere] gxxiong opened a new pull request, #21389: Support the fuzzy query of encrypted fields

gxxiong opened a new pull request, #21389:
URL: https://github.com/apache/shardingsphere/pull/21389

   Fixes #20435.
   
   Changes proposed in this pull request:
     -Support the fuzzy query of encrypted fields
     -Add the fuzzyQueryColumn and fuzzyQueryEncryptorName
     -Provider fuzzy query algorithm, FuzzyChineseEncryptAlgorithm
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [X] I have self-reviewed the commit code.
   - [X] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [X] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] gxxiong commented on pull request #21389: Support the fuzzy query of encrypted fields

Posted by GitBox <gi...@apache.org>.
gxxiong commented on PR #21389:
URL: https://github.com/apache/shardingsphere/pull/21389#issuecomment-1274157610

   @terrymanu #20435 Design Reference assistedQueryColumn, just rewrite LIKE plainColumn into LIKE fuzzyColumn.Then,this pr is to big,I will split the pr into several parts。Now close this pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] gxxiong commented on pull request #21389: Support the fuzzy query of encrypted fields

Posted by GitBox <gi...@apache.org>.
gxxiong commented on PR #21389:
URL: https://github.com/apache/shardingsphere/pull/21389#issuecomment-1272572645

   my wechat id:xionggaoxiang


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] gxxiong closed pull request #21389: Support the fuzzy query of encrypted fields

Posted by GitBox <gi...@apache.org>.
gxxiong closed pull request #21389: Support the fuzzy query of encrypted fields
URL: https://github.com/apache/shardingsphere/pull/21389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] gxxiong closed pull request #21389: Support the fuzzy query of encrypted fields

Posted by GitBox <gi...@apache.org>.
gxxiong closed pull request #21389: Support the fuzzy query of encrypted fields
URL: https://github.com/apache/shardingsphere/pull/21389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #21389: Support the fuzzy query of encrypted fields

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21389:
URL: https://github.com/apache/shardingsphere/pull/21389#issuecomment-1272340279

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21389?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#21389](https://codecov.io/gh/apache/shardingsphere/pull/21389?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7adfd3c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e45c0a9205df1e4a363e6709ac5678e39b75fd42?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e45c0a9) will **decrease** coverage by `0.13%`.
   > The diff coverage is `29.52%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #21389      +/-   ##
   ============================================
   - Coverage     61.58%   61.44%   -0.14%     
     Complexity     2507     2507              
   ============================================
     Files          4089     4091       +2     
     Lines         56609    56843     +234     
     Branches       7487     7530      +43     
   ============================================
   + Hits          34860    34925      +65     
   - Misses        18832    18984     +152     
   - Partials       2917     2934      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pi/config/rule/EncryptColumnRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvYXBpL2NvbmZpZy9ydWxlL0VuY3J5cHRDb2x1bW5SdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...t/rewrite/condition/impl/EncryptLikeCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL2ltcGwvRW5jcnlwdExpa2VDb25kaXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...r/rewriter/EncryptAssignmentParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRBc3NpZ25tZW50UGFyYW1ldGVyUmV3cml0ZXIuamF2YQ==) | `5.40% <0.00%> (-0.48%)` | :arrow_down: |
   | [...ertOnDuplicateKeyUpdateValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRJbnNlcnRPbkR1cGxpY2F0ZUtleVVwZGF0ZVZhbHVlUGFyYW1ldGVyUmV3cml0ZXIuamF2YQ==) | `2.63% <0.00%> (-0.40%)` | :arrow_down: |
   | [.../rewriter/EncryptInsertValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRJbnNlcnRWYWx1ZVBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `1.92% <0.00%> (-0.26%)` | :arrow_down: |
   | [...er/rewriter/EncryptPredicateParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRQcmVkaWNhdGVQYXJhbWV0ZXJSZXdyaXRlci5qYXZh) | `4.76% <0.00%> (-0.51%)` | :arrow_down: |
   | [...ator/EncryptPredicateRightValueTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL0VuY3J5cHRQcmVkaWNhdGVSaWdodFZhbHVlVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `53.84% <0.00%> (-7.92%)` | :arrow_down: |
   | [...onfig/rule/YamlEncryptColumnRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3lhbWwvY29uZmlnL3J1bGUvWWFtbEVuY3J5cHRDb2x1bW5SdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...t/distsql/parser/segment/EncryptColumnSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL3N0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9zZWdtZW50L0VuY3J5cHRDb2x1bW5TZWdtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ncrypt/algorithm/FuzzyChineseEncryptAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L2FsZ29yaXRobS9GdXp6eUNoaW5lc2VFbmNyeXB0QWxnb3JpdGhtLmphdmE=) | `9.37% <9.37%> (ø)` | |
   | ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/21389/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] gxxiong closed pull request #21389: Support the fuzzy query of encrypted fields

Posted by GitBox <gi...@apache.org>.
gxxiong closed pull request #21389: Support the fuzzy query of encrypted fields
URL: https://github.com/apache/shardingsphere/pull/21389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] cheese8 commented on pull request #21389: Support the fuzzy query of encrypted fields

Posted by GitBox <gi...@apache.org>.
cheese8 commented on PR #21389:
URL: https://github.com/apache/shardingsphere/pull/21389#issuecomment-1272571307

   > Thanks for your pr, but it's too big, could you split it into pieces? refer to the subtasks in #20435
   
   Sorry, I means split it into 5 or 6 prs ? And could your provide your wchat code that I invite you into the kernel group.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] cheese8 commented on pull request #21389: Support the fuzzy query of encrypted fields

Posted by GitBox <gi...@apache.org>.
cheese8 commented on PR #21389:
URL: https://github.com/apache/shardingsphere/pull/21389#issuecomment-1272418276

   Thanks for your pr,  but it's too big, could you split it into pieces? refer to the subtasks in #20435 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org