You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "wu-a-ge (via GitHub)" <gi...@apache.org> on 2023/07/18 15:37:19 UTC
[GitHub] [seatunnel] wu-a-ge opened a new pull request, #5114: [Feature][Zeta] Support history service record job execute error
wu-a-ge opened a new pull request, #5114:
URL: https://github.com/apache/seatunnel/pull/5114
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liugddx merged pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx merged PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] Hisoka-X commented on pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1663210811
> I think adding a new state should solve this problem in a new PR rather than in the current PR
Yep, we should do it in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y commented on pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1661765219
Relevant PR: https://github.com/apache/seatunnel/pull/5007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] Hisoka-X commented on pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1641674869
Can you add some test case for this? Thanks. eg: submit a error job the use client method query error msg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] wu-a-ge commented on pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "wu-a-ge (via GitHub)" <gi...@apache.org>.
wu-a-ge commented on PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1645743241
@Hisoka-X @TaoZex test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] wu-a-ge commented on pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "wu-a-ge (via GitHub)" <gi...@apache.org>.
wu-a-ge commented on PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1640471746
close #5113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] wu-a-ge commented on a diff in pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "wu-a-ge (via GitHub)" <gi...@apache.org>.
wu-a-ge commented on code in PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#discussion_r1268826767
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -495,10 +495,11 @@ public PassiveCompletableFuture<Void> savePoint(long jobId) {
public PassiveCompletableFuture<JobResult> waitForJobComplete(long jobId) {
JobMaster runningJobMaster = runningJobMasterMap.get(jobId);
if (runningJobMaster == null) {
- JobStatus jobStatus = jobHistoryService.getJobDetailState(jobId).getJobStatus();
+ JobHistoryService.JobState jobState = jobHistoryService.getJobDetailState(jobId);
CompletableFuture<JobResult> future = new CompletableFuture<>();
- // TODO support history service record job execute error
- future.complete(new JobResult(jobStatus, null));
+ if (jobState == null) future.complete(new JobResult(JobStatus.FAILED, null));
Review Comment:
Here I think we should add a new state to notify the user that the Job is lost, instead of returning FAILED, but the impact of adding the state modification scope is large, so I think we can optimize it later!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y commented on pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1661772122
I suggest adding a new JobStatus, UNKNOWN, when jobState is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] hailin0 commented on pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1653694365
good pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] TaoZex commented on a diff in pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex commented on code in PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#discussion_r1276340939
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -495,10 +495,11 @@ public PassiveCompletableFuture<Void> savePoint(long jobId) {
public PassiveCompletableFuture<JobResult> waitForJobComplete(long jobId) {
JobMaster runningJobMaster = runningJobMasterMap.get(jobId);
if (runningJobMaster == null) {
- JobStatus jobStatus = jobHistoryService.getJobDetailState(jobId).getJobStatus();
+ JobHistoryService.JobState jobState = jobHistoryService.getJobDetailState(jobId);
CompletableFuture<JobResult> future = new CompletableFuture<>();
- // TODO support history service record job execute error
- future.complete(new JobResult(jobStatus, null));
+ if (jobState == null) future.complete(new JobResult(JobStatus.FAILED, null));
Review Comment:
Agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] TaoZex commented on a diff in pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex commented on code in PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#discussion_r1267480287
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -495,10 +495,11 @@ public PassiveCompletableFuture<Void> savePoint(long jobId) {
public PassiveCompletableFuture<JobResult> waitForJobComplete(long jobId) {
JobMaster runningJobMaster = runningJobMasterMap.get(jobId);
if (runningJobMaster == null) {
- JobStatus jobStatus = jobHistoryService.getJobDetailState(jobId).getJobStatus();
+ JobHistoryService.JobState jobState = jobHistoryService.getJobDetailState(jobId);
CompletableFuture<JobResult> future = new CompletableFuture<>();
- // TODO support history service record job execute error
- future.complete(new JobResult(jobStatus, null));
+ if (jobState == null) future.complete(new JobResult(JobStatus.FAILED, null));
Review Comment:
How about changing null (after JobStatus.FAILED) to alert that the job failed?
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -495,10 +495,11 @@ public PassiveCompletableFuture<Void> savePoint(long jobId) {
public PassiveCompletableFuture<JobResult> waitForJobComplete(long jobId) {
JobMaster runningJobMaster = runningJobMasterMap.get(jobId);
if (runningJobMaster == null) {
- JobStatus jobStatus = jobHistoryService.getJobDetailState(jobId).getJobStatus();
+ JobHistoryService.JobState jobState = jobHistoryService.getJobDetailState(jobId);
CompletableFuture<JobResult> future = new CompletableFuture<>();
- // TODO support history service record job execute error
- future.complete(new JobResult(jobStatus, null));
+ if (jobState == null) future.complete(new JobResult(JobStatus.FAILED, null));
Review Comment:
How about changing null (after JobStatus.FAILED) to alert that the job failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] wu-a-ge commented on pull request #5114: [Feature][Zeta] Support history service record job execute error
Posted by "wu-a-ge (via GitHub)" <gi...@apache.org>.
wu-a-ge commented on PR #5114:
URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1641739122
> Can you add some test case for this? Thanks. eg: submit a error job the use client method query error msg.
OK! I will try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org