You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2024/12/13 18:42:16 UTC
[PR] Move test packages in polaris-dropwizard-service module [polaris]
adutra opened a new pull request, #549:
URL: https://github.com/apache/polaris/pull/549
With #523, we forgot to update the root package name in the test folder of polaris-dropwizard-service.
It's important to do this update to avoid the "split packages" issue (packages appearing in more than one module).
This PR has no functional change, however it does make a few methods public in polaris-service-common, in order for them to remain accessible to the moved tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test packages in polaris-dropwizard-service module [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #549:
URL: https://github.com/apache/polaris/pull/549#issuecomment-2660333888
I still see a lot of split package issues, e.g.:
```
> Task :polaris-quarkus-admin:test
Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in multiple archives:
- "org.apache.polaris.admintool.config" found in [org.apache.polaris:polaris-quarkus-admin:1.0.0-incubating-SNAPSHOT]
- "org.apache.polaris.admintool" found in [org.apache.polaris:polaris-quarkus-admin:1.0.0-incubating-SNAPSHOT]
Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in multiple archives:
- "org.apache.polaris.admintool.config" found in [org.apache.polaris:polaris-quarkus-admin:1.0.0-incubating-SNAPSHOT]
- "org.apache.polaris.admintool" found in [org.apache.polaris:polaris-quarkus-admin:1.0.0-incubating-SNAPSHOT]
. . .
```
Do we need to move things around after the admin tool changes @adutra?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move test packages in polaris-dropwizard-service module [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #549:
URL: https://github.com/apache/polaris/pull/549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org