[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1759: [CELEBORN-832] Support use RESTful API to trigger worker decommission

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1759:
URL: https://github.com/apache/incubator-celeborn/pull/1759#discussion_r1276050902


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -592,7 +607,37 @@ private[celeborn] class Worker(
       logWarning(s"Waiting for all PartitionLocation release cost ${waitTime}ms, " +
         s"unreleased PartitionLocation: \n$partitionLocationInfo")
     }
-    stop(CelebornExitKind.WORKER_GRACEFUL_SHUTDOWN)
+  }
+
+  def decommissionWorker(): Unit = {
+    try {
+      masterClient.askSync(
+        ReportWorkerUnavailable(List(workerInfo).asJava),

Review Comment:
   I also noticed this, maybe just send `WorkerLost`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org