You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/06/23 17:43:33 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #199: Add Scala Steward GitHub Action
Shanedell opened a new pull request, #199:
URL: https://github.com/apache/daffodil-vscode/pull/199
- Currently having it running at 2pm everyday so I could test it a bit before merging. This will be change to only run on Sunday mornings every week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #199: Add Scala Steward GitHub Action
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #199:
URL: https://github.com/apache/daffodil-vscode/pull/199#discussion_r905325233
##########
.github/workflows/scala-steward.yml:
##########
@@ -0,0 +1,18 @@
+# This workflow will launch at 00:00 every Sunday
+# This file is based on docs from https://github.com/scala-steward-org/scala-steward-action
+on:
+ schedule:
+ - cron: '0 12 * * *'
+
+name: Scala Steward CI
+
+jobs:
+ scala-steward:
+ runs-on: ubuntu-20.04
+ name: Launch Scala Steward
Review Comment:
Makes sense to me I added this in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #199: Add Scala Steward GitHub Action
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #199:
URL: https://github.com/apache/daffodil-vscode/pull/199#issuecomment-1164734285
Yeah I am going to make an initial commit to have it run everyday so we can get a feel for how it works but after we have it figured out and most of the stuff is updated I would like to move it to be only once a week no Sundays or something. That way for both Node and Scala updates we can get them squared away on Mondays
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #199: Add Scala Steward GitHub Action
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #199:
URL: https://github.com/apache/daffodil-vscode/pull/199#discussion_r905325879
##########
.github/workflows/scala-steward.yml:
##########
@@ -0,0 +1,18 @@
+# This workflow will launch at 00:00 every Sunday
Review Comment:
Yeah missed that initially, I added it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #199: Add Scala Steward GitHub Action
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #199:
URL: https://github.com/apache/daffodil-vscode/pull/199#discussion_r905310746
##########
.github/workflows/scala-steward.yml:
##########
@@ -0,0 +1,18 @@
+# This workflow will launch at 00:00 every Sunday
+# This file is based on docs from https://github.com/scala-steward-org/scala-steward-action
+on:
+ schedule:
+ - cron: '0 12 * * *'
+
+name: Scala Steward CI
+
+jobs:
+ scala-steward:
+ runs-on: ubuntu-20.04
+ name: Launch Scala Steward
Review Comment:
Should we add an `if` condition so that this is only triggered on the `apache/daffodil-vscode` repo? If someone creates a fork of the repo we probably don't want their fork to be spammed with PR's updating dependencies. Dependabot does that right now with no way to disable it and I find it pretty annoying.
I think something like would work:
```yaml
jobs:
scala-steward:
if: github.repository == 'apache/daffodil-vscode'
...
```
##########
.github/workflows/scala-steward.yml:
##########
@@ -0,0 +1,18 @@
+# This workflow will launch at 00:00 every Sunday
Review Comment:
Needs an apache license to pass the rat check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien commented on pull request #199: Add Scala Steward GitHub Action
Posted by GitBox <gi...@apache.org>.
arosien commented on PR #199:
URL: https://github.com/apache/daffodil-vscode/pull/199#issuecomment-1169020626
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #199: Add Scala Steward GitHub Action
Posted by GitBox <gi...@apache.org>.
Shanedell merged PR #199:
URL: https://github.com/apache/daffodil-vscode/pull/199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #199: Add Scala Steward GitHub Action
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #199:
URL: https://github.com/apache/daffodil-vscode/pull/199#issuecomment-1169024468
@arosien Can you:
- go to `Files Changed`
- click `Review Changes`
- select `Approve`
- type `+1` as the comment
- clci `Submit Review`
That will make sure we get the green checkmark that you approved the changes of the PR. I believe you approved the other PR as well so you will need to do this for that one as well, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org