You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/07 10:42:26 UTC
[jira] [Commented] (CB-9760) InAppBrowser: fallback to default
windows.open behavior on Ripple
[ https://issues.apache.org/jira/browse/CB-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946518#comment-14946518 ]
ASF GitHub Bot commented on CB-9760:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/118
CB-9760 InAppBrowser: fallback to default windows.open behavior on Ripple
https://issues.apache.org/jira/browse/CB-9760
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-9760
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #118
----
commit fed9f6b63acb110acf87b0d72410a1ec433b7466
Author: sgrebnov <v-...@microsoft.com>
Date: 2015-10-07T08:40:25Z
CB-9760 InAppBrowser: fallback to default windows.open behaviour on Ripple
----
> InAppBrowser: fallback to default windows.open behavior on Ripple
> -----------------------------------------------------------------
>
> Key: CB-9760
> URL: https://issues.apache.org/jira/browse/CB-9760
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin InAppBrowser
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
>
> There are complains that InAppBrowser and dependent plugins don't work when emulated using Ripple. So plugin developers have to use special tricks to fallback to default windows.open behavior in case of Ripple, for example
> https://github.com/Azure/azure-mobile-services-cordova/blob/master/www/MobileServices.Web.Ext.js#L22
> I propose to include this to InAppBrowser plugin so that it work automatically
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org