You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Bram de Kruijff (JIRA)" <ji...@apache.org> on 2012/05/20 17:03:41 UTC
[jira] [Created] (FELIX-3515) DeploymentAdmin triggers IOException
on install
Bram de Kruijff created FELIX-3515:
--------------------------------------
Summary: DeploymentAdmin triggers IOException on install
Key: FELIX-3515
URL: https://issues.apache.org/jira/browse/FELIX-3515
Project: Felix
Issue Type: Bug
Components: Deployment Admin
Environment: r1339925
Reporter: Bram de Kruijff
Priority: Critical
The commit in r1339925 introduced an IOException that will happen always, but may or may not have an effect (concurrency).
Issue it the ExplodingOutputtingInputStream#run() will always try to read an InputStream it has already closed itself. As the IOException is now also pushed to the calling thread this cause the deployment to fail.
{code}
java.io.IOException: Exception while processing the stream in the background: Pipe closed
at org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.close(ExplodingOutputtingInputStream.java:73)
at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:217)
at org.amdatu.itest.base.impl.TestContextImpl.installDeploymentPackage(TestContextImpl.java:94)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FELIX-3515) DeploymentAdmin triggers IOException
on install
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Offermans reassigned FELIX-3515:
---------------------------------------
Assignee: Marcel Offermans
> DeploymentAdmin triggers IOException on install
> -----------------------------------------------
>
> Key: FELIX-3515
> URL: https://issues.apache.org/jira/browse/FELIX-3515
> Project: Felix
> Issue Type: Bug
> Components: Deployment Admin
> Environment: r1339925
> Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
> Maven home: C:\Program Files\Apache Maven\apache-maven-3.0.4
> Java version: 1.7.0_02, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_02\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Bram de Kruijff
> Assignee: Marcel Offermans
> Priority: Critical
> Attachments: FELIX-3515_ExplodingOutputtingInputStream_DontReadFromClosedStream.java
>
>
> The commit in r1339925 introduced an IOException that will happen always, but may or may not have an effect (concurrency).
> Issue it the ExplodingOutputtingInputStream#run() will always try to read an InputStream it has already closed itself. As the IOException is now also pushed to the calling thread this cause the deployment to fail.
> {code}
> java.io.IOException: Exception while processing the stream in the background: Pipe closed
> at org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.close(ExplodingOutputtingInputStream.java:73)
> at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:217)
> at org.amdatu.itest.base.impl.TestContextImpl.installDeploymentPackage(TestContextImpl.java:94)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3515) DeploymentAdmin triggers IOException
on install
Posted by "Bram de Kruijff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bram de Kruijff updated FELIX-3515:
-----------------------------------
Attachment: FELIX-3515_ExplodingOutputtingInputStream_DontReadFromClosedStream.java
Attached patch. I think simply removing the offending code solves the issue without risk.
> DeploymentAdmin triggers IOException on install
> -----------------------------------------------
>
> Key: FELIX-3515
> URL: https://issues.apache.org/jira/browse/FELIX-3515
> Project: Felix
> Issue Type: Bug
> Components: Deployment Admin
> Environment: r1339925
> Reporter: Bram de Kruijff
> Priority: Critical
> Attachments: FELIX-3515_ExplodingOutputtingInputStream_DontReadFromClosedStream.java
>
>
> The commit in r1339925 introduced an IOException that will happen always, but may or may not have an effect (concurrency).
> Issue it the ExplodingOutputtingInputStream#run() will always try to read an InputStream it has already closed itself. As the IOException is now also pushed to the calling thread this cause the deployment to fail.
> {code}
> java.io.IOException: Exception while processing the stream in the background: Pipe closed
> at org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.close(ExplodingOutputtingInputStream.java:73)
> at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:217)
> at org.amdatu.itest.base.impl.TestContextImpl.installDeploymentPackage(TestContextImpl.java:94)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3515) DeploymentAdmin triggers IOException
on install
Posted by "Bram de Kruijff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bram de Kruijff updated FELIX-3515:
-----------------------------------
Environment:
r1339925
Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
Maven home: C:\Program Files\Apache Maven\apache-maven-3.0.4
Java version: 1.7.0_02, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_02\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
was:r1339925
> DeploymentAdmin triggers IOException on install
> -----------------------------------------------
>
> Key: FELIX-3515
> URL: https://issues.apache.org/jira/browse/FELIX-3515
> Project: Felix
> Issue Type: Bug
> Components: Deployment Admin
> Environment: r1339925
> Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
> Maven home: C:\Program Files\Apache Maven\apache-maven-3.0.4
> Java version: 1.7.0_02, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_02\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Bram de Kruijff
> Priority: Critical
> Attachments: FELIX-3515_ExplodingOutputtingInputStream_DontReadFromClosedStream.java
>
>
> The commit in r1339925 introduced an IOException that will happen always, but may or may not have an effect (concurrency).
> Issue it the ExplodingOutputtingInputStream#run() will always try to read an InputStream it has already closed itself. As the IOException is now also pushed to the calling thread this cause the deployment to fail.
> {code}
> java.io.IOException: Exception while processing the stream in the background: Pipe closed
> at org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.close(ExplodingOutputtingInputStream.java:73)
> at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:217)
> at org.amdatu.itest.base.impl.TestContextImpl.installDeploymentPackage(TestContextImpl.java:94)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3515) DeploymentAdmin triggers
IOException on install
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280019#comment-13280019 ]
Marcel Offermans commented on FELIX-3515:
-----------------------------------------
Applying the patch would re-introduce FELIX-3336, but I completely agree that the current code does not work correctly as the stream we're reading from is closed too early. I'll work on a different fix.
> DeploymentAdmin triggers IOException on install
> -----------------------------------------------
>
> Key: FELIX-3515
> URL: https://issues.apache.org/jira/browse/FELIX-3515
> Project: Felix
> Issue Type: Bug
> Components: Deployment Admin
> Environment: r1339925
> Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
> Maven home: C:\Program Files\Apache Maven\apache-maven-3.0.4
> Java version: 1.7.0_02, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_02\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Bram de Kruijff
> Priority: Critical
> Attachments: FELIX-3515_ExplodingOutputtingInputStream_DontReadFromClosedStream.java
>
>
> The commit in r1339925 introduced an IOException that will happen always, but may or may not have an effect (concurrency).
> Issue it the ExplodingOutputtingInputStream#run() will always try to read an InputStream it has already closed itself. As the IOException is now also pushed to the calling thread this cause the deployment to fail.
> {code}
> java.io.IOException: Exception while processing the stream in the background: Pipe closed
> at org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.close(ExplodingOutputtingInputStream.java:73)
> at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:217)
> at org.amdatu.itest.base.impl.TestContextImpl.installDeploymentPackage(TestContextImpl.java:94)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (FELIX-3515) DeploymentAdmin triggers IOException
on install
Posted by "Bram de Kruijff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bram de Kruijff closed FELIX-3515.
----------------------------------
Seems to do the trick. I can no longer reproduce it and that makes sense looking at the commit. Thanks!
> DeploymentAdmin triggers IOException on install
> -----------------------------------------------
>
> Key: FELIX-3515
> URL: https://issues.apache.org/jira/browse/FELIX-3515
> Project: Felix
> Issue Type: Bug
> Components: Deployment Admin
> Environment: r1339925
> Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
> Maven home: C:\Program Files\Apache Maven\apache-maven-3.0.4
> Java version: 1.7.0_02, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_02\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Bram de Kruijff
> Assignee: Marcel Offermans
> Priority: Critical
> Attachments: FELIX-3515_ExplodingOutputtingInputStream_DontReadFromClosedStream.java
>
>
> The commit in r1339925 introduced an IOException that will happen always, but may or may not have an effect (concurrency).
> Issue it the ExplodingOutputtingInputStream#run() will always try to read an InputStream it has already closed itself. As the IOException is now also pushed to the calling thread this cause the deployment to fail.
> {code}
> java.io.IOException: Exception while processing the stream in the background: Pipe closed
> at org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.close(ExplodingOutputtingInputStream.java:73)
> at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:217)
> at org.amdatu.itest.base.impl.TestContextImpl.installDeploymentPackage(TestContextImpl.java:94)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-3515) DeploymentAdmin triggers IOException
on install
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Offermans resolved FELIX-3515.
-------------------------------------
Resolution: Fixed
Please re-test and close if fixed for you.
> DeploymentAdmin triggers IOException on install
> -----------------------------------------------
>
> Key: FELIX-3515
> URL: https://issues.apache.org/jira/browse/FELIX-3515
> Project: Felix
> Issue Type: Bug
> Components: Deployment Admin
> Environment: r1339925
> Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
> Maven home: C:\Program Files\Apache Maven\apache-maven-3.0.4
> Java version: 1.7.0_02, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_02\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Bram de Kruijff
> Assignee: Marcel Offermans
> Priority: Critical
> Attachments: FELIX-3515_ExplodingOutputtingInputStream_DontReadFromClosedStream.java
>
>
> The commit in r1339925 introduced an IOException that will happen always, but may or may not have an effect (concurrency).
> Issue it the ExplodingOutputtingInputStream#run() will always try to read an InputStream it has already closed itself. As the IOException is now also pushed to the calling thread this cause the deployment to fail.
> {code}
> java.io.IOException: Exception while processing the stream in the background: Pipe closed
> at org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.close(ExplodingOutputtingInputStream.java:73)
> at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:217)
> at org.amdatu.itest.base.impl.TestContextImpl.installDeploymentPackage(TestContextImpl.java:94)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira