You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/03/26 16:56:32 UTC
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12859
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
IMPALA-8362: Increase authorization test coverage with local catalog
This patch adds authorization test that runs with local catalog by
reusing the existing grant and revoke tests.
Testing:
- Added a new authorization test with local catalog
- Ran all authorization tests
Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
---
M tests/authorization/test_grant_revoke.py
1 file changed, 20 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/12859/2
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2541/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Mar 2019 17:40:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3957/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Mar 2019 18:00:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2543/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Mar 2019 18:24:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Mar 2019 22:42:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
Patch Set 2: Code-Review+2
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py
File tests/authorization/test_grant_revoke.py:
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@112
PS2, Line 112: global_catalog
Don't think the code refers to it as global_catalog. Call it default_catalog or v1_catalog or something?
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@113
PS2, Line 113: non-local catalog
If local catalog becomes default, this is stale. May be can just call default?
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@118
PS2, Line 118: 1
nit: true (to be consistent with other tests)
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@120
PS2, Line 120: 1
same.
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Mar 2019 17:42:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
IMPALA-8362: Increase authorization test coverage with local catalog
This patch adds authorization test that runs with local catalog by
reusing the existing grant and revoke tests.
Testing:
- Added a new authorization test with local catalog
- Ran all authorization tests
Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Reviewed-on: http://gerrit.cloudera.org:8080/12859
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/authorization/test_grant_revoke.py
1 file changed, 20 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Mar 2019 18:00:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
Patch Set 3: Code-Review+2
(4 comments)
Carry Bharath's +2.
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py
File tests/authorization/test_grant_revoke.py:
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@112
PS2, Line 112: catalog_v1(sel
> Don't think the code refers to it as global_catalog. Call it default_catalo
Done
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@113
PS2, Line 113: catalog v1."""
> If local catalog becomes default, this is stale. May be can just call defau
Done
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@118
PS2, Line 118: t
> nit: true (to be consistent with other tests)
Done
http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@120
PS2, Line 120: t
> same.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Mar 2019 18:00:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog
......................................................................
IMPALA-8362: Increase authorization test coverage with local catalog
This patch adds authorization test that runs with local catalog by
reusing the existing grant and revoke tests.
Testing:
- Added a new authorization test with local catalog
- Ran all authorization tests
Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
---
M tests/authorization/test_grant_revoke.py
1 file changed, 20 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/12859/3
--
To view, visit http://gerrit.cloudera.org:8080/12859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a
Gerrit-Change-Number: 12859
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>