You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/17 01:43:46 UTC

[GitHub] [arrow] wgtmac commented on a diff in pull request #33703: GH-14748:[C++] Modify some comments about shared_ptr's ownership in parquet-cpp.

wgtmac commented on code in PR #33703:
URL: https://github.com/apache/arrow/pull/33703#discussion_r1071668683


##########
cpp/src/parquet/column_reader.h:
##########
@@ -151,7 +151,7 @@ class PARQUET_EXPORT PageReader {
   }
 
   // @returns: shared_ptr<Page>(nullptr) on EOS, std::shared_ptr<Page>
-  // containing new Page otherwise
+  // containing new Page otherwise. This object must not outlive the PageReader.

Review Comment:
   I would say it is fine if the buffer (as well as the page object) outlives the PageReader. But its lifecycle is bound to the memory pool which allocates the buffer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org