You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/13 23:20:20 UTC
[jira] [Commented] (BEAM-432) BigQueryIO javadoc is incorrect
[ https://issues.apache.org/jira/browse/BEAM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420115#comment-15420115 ]
ASF GitHub Bot commented on BEAM-432:
-------------------------------------
GitHub user mariusz89016 opened a pull request:
https://github.com/apache/incubator-beam/pull/823
[BEAM-432] Corrected BigQueryIO javadoc
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Link to the issue: https://issues.apache.org/jira/browse/BEAM-432
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mariusz89016/incubator-beam fix-bigquery-javadoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #823
----
commit 54b0514371a1028b271d03cc309e6f66fb909e28
Author: mariusz89016 <ma...@gmail.com>
Date: 2016-08-13T22:35:19Z
[BEAM-432] Corrected BigQueryIO javadoc
----
> BigQueryIO javadoc is incorrect
> -------------------------------
>
> Key: BEAM-432
> URL: https://issues.apache.org/jira/browse/BEAM-432
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-gcp
> Affects Versions: 0.1.0-incubating, 0.2.0-incubating
> Reporter: Daniel Halperin
> Priority: Trivial
> Labels: newbie, starter
>
> BigQueryIO has a broken code snippet in its Javadoc:
> The table name in fromQuery() should be within square brackets i.e.
> .fromQuery("SELECT year, mean_temp FROM samples.weather_stations")
> should be:
> .fromQuery("SELECT year, mean_temp FROM [samples.weather_stations]")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)