You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2016/12/08 11:16:28 UTC
mesos git commit: Fixed inaccurate documentation of `--hostname` for
master and agent.
Repository: mesos
Updated Branches:
refs/heads/master 13774a4d4 -> 99b40a224
Fixed inaccurate documentation of `--hostname` for master and agent.
This comment is inaccurate since the introduction of
`LIBPROCESS_ADVERTISE_IP`, which introduced the distinction between the
IP that we bind to vs advertise.
If the `--hostname` flag is unset, it is resolved from the IP address
that the master/agent advertises. This may happen to be same as the IP
address that we bind to, but ultimately we resolve it based on the
advertise IP.
Review: https://reviews.apache.org/r/54275/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/99b40a22
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/99b40a22
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/99b40a22
Branch: refs/heads/master
Commit: 99b40a2245110a22471cd5132579513fa68850e0
Parents: 13774a4
Author: Michael Park <mp...@apache.org>
Authored: Thu Dec 8 03:16:00 2016 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Thu Dec 8 03:16:00 2016 -0800
----------------------------------------------------------------------
src/master/flags.cpp | 2 +-
src/slave/flags.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/99b40a22/src/master/flags.cpp
----------------------------------------------------------------------
diff --git a/src/master/flags.cpp b/src/master/flags.cpp
index 9bfb40e..e5edf33 100644
--- a/src/master/flags.cpp
+++ b/src/master/flags.cpp
@@ -37,7 +37,7 @@ mesos::internal::master::Flags::Flags()
"hostname",
"The hostname the master should advertise in ZooKeeper.\n"
"If left unset, the hostname is resolved from the IP address\n"
- "that the agent binds to; unless the user explicitly prevents\n"
+ "that the master advertises; unless the user explicitly prevents\n"
"that, using `--no-hostname_lookup`, in which case the IP itself\n"
"is used.");
http://git-wip-us.apache.org/repos/asf/mesos/blob/99b40a22/src/slave/flags.cpp
----------------------------------------------------------------------
diff --git a/src/slave/flags.cpp b/src/slave/flags.cpp
index d66e9d4..74a6c99 100644
--- a/src/slave/flags.cpp
+++ b/src/slave/flags.cpp
@@ -44,7 +44,7 @@ mesos::internal::slave::Flags::Flags()
"hostname",
"The hostname the agent should report.\n"
"If left unset, the hostname is resolved from the IP address\n"
- "that the agent binds to; unless the user explicitly prevents\n"
+ "that the agent advertises; unless the user explicitly prevents\n"
"that, using `--no-hostname_lookup`, in which case the IP itself\n"
"is used.");