You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Kamil Wasilewski <ka...@polidea.com> on 2020/11/09 11:36:19 UTC
Re: Jenkins trigger phrase "run seed job" not working?
Has anyone noticed problems with running "run seed job" by committers when
the author of the Pull Request is NOT a committer? For example:
https://github.com/apache/beam/pull/13242. Neither I nor Valentyn could
trigger the job. Does it mean that it's an author's username that really
matters, not a commentator's username?
Re: Jenkins trigger phrase "run seed job" not working?
Posted by Valentyn Tymofieiev <va...@google.com>.
On Mon, Nov 9, 2020 at 3:32 PM Valentyn Tymofieiev <va...@google.com>
wrote:
> I actually added a commit on that PR and it still didn't work:
> https://github.com/apache/beam/pull/13242/commits/b9a872b039b5ff27b2678365ec777b64acb18a0e
> .
> I'll try to clone the PR and trigger the seed job as a workaround.
>
The workaround worked: https://github.com/apache/beam/pull/13288.
>
> On Mon, Nov 9, 2020 at 10:46 AM Udi Meiri <eh...@google.com> wrote:
>
>> Yeah, I've had that issue recently:
>> https://github.com/apache/beam/pull/13213 (seed job did not trigger)
>>
>> I've personally never seen where this is configured, but it sounds like
>> it.
>> What happens if you edit a file in the PR? It should make you a co-author.
>>
>> On Mon, Nov 9, 2020 at 3:36 AM Kamil Wasilewski <
>> kamil.wasilewski@polidea.com> wrote:
>>
>>> Has anyone noticed problems with running "run seed job" by committers
>>> when the author of the Pull Request is NOT a committer? For example:
>>> https://github.com/apache/beam/pull/13242. Neither I nor Valentyn could
>>> trigger the job. Does it mean that it's an author's username that really
>>> matters, not a commentator's username?
>>>
>>
Re: Jenkins trigger phrase "run seed job" not working?
Posted by Valentyn Tymofieiev <va...@google.com>.
I actually added a commit on that PR and it still didn't work:
https://github.com/apache/beam/pull/13242/commits/b9a872b039b5ff27b2678365ec777b64acb18a0e
.
I'll try to clone the PR and trigger the seed job as a workaround.
On Mon, Nov 9, 2020 at 10:46 AM Udi Meiri <eh...@google.com> wrote:
> Yeah, I've had that issue recently:
> https://github.com/apache/beam/pull/13213 (seed job did not trigger)
>
> I've personally never seen where this is configured, but it sounds like it.
> What happens if you edit a file in the PR? It should make you a co-author.
>
> On Mon, Nov 9, 2020 at 3:36 AM Kamil Wasilewski <
> kamil.wasilewski@polidea.com> wrote:
>
>> Has anyone noticed problems with running "run seed job" by committers
>> when the author of the Pull Request is NOT a committer? For example:
>> https://github.com/apache/beam/pull/13242. Neither I nor Valentyn could
>> trigger the job. Does it mean that it's an author's username that really
>> matters, not a commentator's username?
>>
>
Re: Jenkins trigger phrase "run seed job" not working?
Posted by Udi Meiri <eh...@google.com>.
Yeah, I've had that issue recently:
https://github.com/apache/beam/pull/13213 (seed job did not trigger)
I've personally never seen where this is configured, but it sounds like it.
What happens if you edit a file in the PR? It should make you a co-author.
On Mon, Nov 9, 2020 at 3:36 AM Kamil Wasilewski <
kamil.wasilewski@polidea.com> wrote:
> Has anyone noticed problems with running "run seed job" by committers when
> the author of the Pull Request is NOT a committer? For example:
> https://github.com/apache/beam/pull/13242. Neither I nor Valentyn could
> trigger the job. Does it mean that it's an author's username that really
> matters, not a commentator's username?
>