You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 01:34:56 UTC

[GitHub] [arrow] AlvinJ15 commented on a diff in pull request #12702: ARROW-15062: [C++] Add memory information to current spans

AlvinJ15 commented on code in PR #12702:
URL: https://github.com/apache/arrow/pull/12702#discussion_r848994594


##########
cpp/src/arrow/util/io_util.cc:
##########
@@ -97,10 +97,32 @@
 #include "arrow/util/logging.h"
 
 // For filename conversion
-#if defined(_WIN32)
+#ifdef _WIN32
 #include "arrow/util/utf8.h"
 #endif
 
+#ifdef _WIN32
+#include <psapi.h>
+#include <windows.h>
+
+#elif __unix__ || __unix || unix || (__APPLE__ && __MACH__)
+#include <sys/resource.h>
+
+#if __APPLE__ && __MACH__
+#include <mach/mach.h>
+
+#elif (_AIX || __TOS__AIX__) || (__sun__ || __sun || sun && (_SVR4 || __svr4__))
+#include <procfs.h>

Review Comment:
   it was unused and was removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org