[GitHub] [tinkerpop] spmallette commented on issue #1118: TINKERPOP-2224 Detect and fix iterator leaks

[GitBox <gi...@apache.org>]

spmallette commented on issue #1118: TINKERPOP-2224 Detect and fix iterator leaks
URL: https://github.com/apache/tinkerpop/pull/1118#issuecomment-499060447
 
 
   Note that we've re-opened the releases branches for development so `tp33` is now on 3.8.0-SNAPSHOT. 
   
   > I did not get time to look at those tests yet. I will take them up in the coming weeks.
   
   ok - i'm sorry, but it's not clear from your response if you intend to make those changes on this PR or a future one. i think i'm ok to merge this as-is because it's not really introducing a new problem, so much as shedding light on one. i just wouldn't want to forget that we have those leaks that need review.
   
   upon further thought, i think it would be nice if this PR had some Upgrade Documentation for providers to call their attention to what's been done here.  Maybe there should even be some details in the [Provider documentation](http://tinkerpop.apache.org/docs/current/dev/provider/#_implementing_gremlin_core)? Including some docs of this nature would be a nice addition, but I can probably write something up on merge if you like. Just let me know.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services