You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mikhail Khludnev (JIRA)" <ji...@apache.org> on 2018/04/13 21:24:00 UTC
[jira] [Comment Edited] (SOLR-5859) Harden the Overseer restart
mechanism
[ https://issues.apache.org/jira/browse/SOLR-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437946#comment-16437946 ]
Mikhail Khludnev edited comment on SOLR-5859 at 4/13/18 9:23 PM:
-----------------------------------------------------------------
[~noble.paul], I want to clarify
https://github.com/apache/lucene-solr/commit/3fd292234166105f96fcb5acd3999c9c2abff737#diff-9ed614eee66b9e685d73446b775dc043R287
{code}
//do this in a separate thread because any wait is interrupted in this main thread
new Thread(this::checkIfIamStillLeader, "OverseerExitThread").start();
{code}
Can't we clean interrupt flag with {{Thread.interrupted()}} and avoid spawning new thread ?
was (Author: mkhludnev):
[~noble.paul], I want to clarify
https://github.com/apache/lucene-solr/commit/3fd292234166105f96fcb5acd3999c9c2abff737#diff-9ed614eee66b9e685d73446b775dc043R287
{quote}
//do this in a separate thread because any wait is interrupted in this main thread
new Thread(this::checkIfIamStillLeader, "OverseerExitThread").start();
{quote}
Can't we clean interrupt flag with {{Thread.interrupted()}} and avoid spawning new thread ?
> Harden the Overseer restart mechanism
> -------------------------------------
>
> Key: SOLR-5859
> URL: https://issues.apache.org/jira/browse/SOLR-5859
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Major
> Fix For: 4.8, 6.0
>
> Attachments: SOLR-5859.patch, SOLR-5859.patch, SOLR-5859.patch, SOLR-5859.patch
>
>
> SOLR-5476 depends on Overseer restart.The current strategy is to remove the zk node for leader election and wait for STATUS_UPDATE_DELAY +100 ms and start the new overseer.
> Though overseer ops are short running, it is not a 100% foolproof strategy because if an operation takes longer than the wait period there can be race condition.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org