You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/22 15:23:48 UTC

[GitHub] srowen commented on a change in pull request #23846: [SPARK-26729][K8S] Make image names under test configurable

srowen commented on a change in pull request #23846: [SPARK-26729][K8S] Make image names under test configurable
URL: https://github.com/apache/spark/pull/23846#discussion_r259386394
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/pom.xml
 ##########
 @@ -148,6 +148,9 @@
             <spark.kubernetes.test.master>${spark.kubernetes.test.master}</spark.kubernetes.test.master>
             <spark.kubernetes.test.namespace>${spark.kubernetes.test.namespace}</spark.kubernetes.test.namespace>
             <spark.kubernetes.test.serviceAccountName>${spark.kubernetes.test.serviceAccountName}</spark.kubernetes.test.serviceAccountName>
+            <spark.kubernetes.test.jvmImage>${spark.kubernetes.test.jvmImage}</spark.kubernetes.test.jvmImage>
 
 Review comment:
   I know this isn't new, but do all of these have to be system properties vs some command line argument somewhere? Probably, and it's fine, just checking

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org