You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Li Jing Qin (JIRA)" <ji...@apache.org> on 2010/05/28 10:21:43 UTC

[jira] Created: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

[jdktools]hdk javac only support compliance 1.5
-----------------------------------------------

                 Key: HARMONY-6529
                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
             Project: Harmony
          Issue Type: Bug
         Environment: All
            Reporter: Li Jing Qin
            Priority: Minor
         Attachments: HARMONY-6529.diff

In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by Charles Lee <li...@gmail.com>.
Hi Nathan,

The original issue is: I am using harmony6 to compile hadoop. The compile is
not successful because hadoop need compile the class as 1.6. I agree with
you. I will provide 1.6 patch for the branch 6.

On Mon, May 31, 2010 at 4:01 AM, Nathan Beyer (JIRA) <ji...@apache.org>wrote:

>
>    [
> https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873477#action_12873477]
>
> Nathan Beyer commented on HARMONY-6529:
> ---------------------------------------
>
> What's the issue? If you're trying to compile 1.6 source or target, this
> won't work with the HDK5 code. If you're doing that with HDK6, then we
> probably do need to adjust the compliance level to '-1.6' for that branch.
>
> > [jdktools]hdk javac only support compliance 1.5
> > -----------------------------------------------
> >
> >                 Key: HARMONY-6529
> >                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
> >             Project: Harmony
> >          Issue Type: Bug
> >         Environment: All
> >            Reporter: Li Jing Qin
> >            Priority: Minor
> >         Attachments: HARMONY-6529.diff
> >
> >
> > In
> jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java,
> we are add '-1.5' as the compliance level. This will override any specify
> level which given by the user. For example, javac -source 1.6 -target 1.6
> will report unsupport. A simply change '-1.5' to '-1.7' will solve this
> problem. From the page
> http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm,
> we can find jdt compiler supports '-1.7'.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


-- 
Yours sincerely,
Charles Lee

[jira] Assigned: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess reassigned HARMONY-6529:
-------------------------------------

    Assignee: Mark Hindess

> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Assignee: Mark Hindess
>            Priority: Minor
>         Attachments: HARMONY-6529.diff, HARMONY-6529_Java6.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873294#action_12873294 ] 

Nathan Beyer commented on HARMONY-6529:
---------------------------------------

I don't think we want to change this, as the compliance level is how defaults are set, isn't it? For HDK5, we want the compliance level at 1.5; for HDK6, we want the compliance level at 1.6.

> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Priority: Minor
>         Attachments: HARMONY-6529.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873373#action_12873373 ] 

Li Jing Qin commented on HARMONY-6529:
--------------------------------------


Yeah. I agree.
Maybe move '-1.5' before the user define arguments will solve this problem.
I will test the priority of the java arguments.




-- 
Yours sincerely,
Charles Lee


> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Priority: Minor
>         Attachments: HARMONY-6529.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Jing Qin updated HARMONY-6529:
---------------------------------

    Attachment: HARMONY-6529.diff

> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Priority: Minor
>         Attachments: HARMONY-6529.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Jing Qin closed HARMONY-6529.
--------------------------------


Verified. Thanks Mark.

> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Assignee: Mark Hindess
>            Priority: Minor
>             Fix For: 6.0M3
>
>         Attachments: HARMONY-6529.diff, HARMONY-6529_Java6.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Jing Qin updated HARMONY-6529:
---------------------------------

    Attachment: HARMONY-6529_Java6.diff

This is the patch for java6 branch.

> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Priority: Minor
>         Attachments: HARMONY-6529.diff, HARMONY-6529_Java6.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873477#action_12873477 ] 

Nathan Beyer commented on HARMONY-6529:
---------------------------------------

What's the issue? If you're trying to compile 1.6 source or target, this won't work with the HDK5 code. If you're doing that with HDK6, then we probably do need to adjust the compliance level to '-1.6' for that branch.

> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Priority: Minor
>         Attachments: HARMONY-6529.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915209#action_12915209 ] 

Li Jing Qin commented on HARMONY-6529:
--------------------------------------

Hi guys, since HARMONY-6437 has been resolved, would anyone give this patch another try?

> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Assignee: Mark Hindess
>            Priority: Minor
>             Fix For: 6.0M3
>
>         Attachments: HARMONY-6529.diff, HARMONY-6529_Java6.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915314#action_12915314 ] 

Mark Hindess commented on HARMONY-6529:
---------------------------------------

I've re-applied the java6 patch at r1001743.

> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Assignee: Mark Hindess
>            Priority: Minor
>             Fix For: 6.0M3
>
>         Attachments: HARMONY-6529.diff, HARMONY-6529_Java6.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6529) [jdktools]hdk javac only support compliance 1.5

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess resolved HARMONY-6529.
-----------------------------------

    Fix Version/s: 6.0M3
       Resolution: Fixed

I've applied the java6 patch at r979981.  Please confirm (by closing this JIRA) that it has been applied as expected and resolves this issue.


> [jdktools]hdk javac only support compliance 1.5
> -----------------------------------------------
>
>                 Key: HARMONY-6529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6529
>             Project: Harmony
>          Issue Type: Bug
>         Environment: All
>            Reporter: Li Jing Qin
>            Assignee: Mark Hindess
>            Priority: Minor
>             Fix For: 6.0M3
>
>         Attachments: HARMONY-6529.diff, HARMONY-6529_Java6.diff
>
>
> In jdktools/modules/jdktools/src/main/java/org/apache/harmony/tools/javac/Main.java, we are add '-1.5' as the compliance level. This will override any specify level which given by the user. For example, javac -source 1.6 -target 1.6 will report unsupport. A simply change '-1.5' to '-1.7' will solve this problem. From the page http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm, we can find jdt compiler supports '-1.7'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.