You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/07 21:56:02 UTC

[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring

clebertsuconic edited a comment on issue #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring
URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-610639997
 
 
   @michaelpearce-gain I actually rebased this locally and it's building fine. it's probably some intermittent issue on the CI.
   
   @fvaleri  Can you rebase it and push -f?
   
   
   can you describe what you have moved here?
   
   
   i'm trying to understand the gain of these changes.
   
   
   I remember when i wrote this I couldn't put the OpenWire in the same classModel I did for AMQP. Is that what you accomplished here?
   
   
   if so.. what exactly did you move? it's kind of hard to see if there was no changes in here. and the benefit of such change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services