You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/21 14:23:09 UTC
[GitHub] [arrow-datafusion] andygrove opened a new issue, #2308: Update LogicalPlan rustdoc code to not use LogicalPlanBuilder
andygrove opened a new issue, #2308:
URL: https://github.com/apache/arrow-datafusion/issues/2308
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
In https://github.com/apache/arrow-datafusion/pull/2294 we move the `LogicalPlan` struct from the `datafusion` crate to the `datafusion-expr` crate. Unfortunately, the rustdoc on some methods reference `LogicalPlanBuilder`, which remains in the `datafusion` crate, so the rustdoc was tagged with `ignore` to stop cargo from testing that code.
**Describe the solution you'd like**
Either update the code to not use `LogicalPlanBuilder` (or move `LogicalPlanBuilder` to the `datafusion-expr` crate, but that may be a large task and require other dependencies to be moved).
**Describe alternatives you've considered**
None
**Additional context**
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #2308: Update LogicalPlan rustdoc code to not use LogicalPlanBuilder
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #2308:
URL: https://github.com/apache/arrow-datafusion/issues/2308#issuecomment-1130015883
Also need to unignore rustdoc in LogicalPlanBuilder and find a replacement for `scan_empty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed issue #2308: Update LogicalPlan rustdoc code to not use LogicalPlanBuilder
Posted by GitBox <gi...@apache.org>.
andygrove closed issue #2308: Update LogicalPlan rustdoc code to not use LogicalPlanBuilder
URL: https://github.com/apache/arrow-datafusion/issues/2308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org