[GitHub] [incubator-doris] ccoffline commented on pull request #6577: Custom config handler #6508

[GitBox <gi...@apache.org>]

ccoffline commented on pull request #6577:
URL: https://github.com/apache/incubator-doris/pull/6577#issuecomment-914900742


   > Could your explain more about `query traffic limit` in your issue #6508 ?
   
   I didn't put `query traffic limit` in this pr. This is still experimental on one of our clusters.
   
   Some users want to limit query more flexibly than `maxQueryInstances` #6159. For example, all query should be rejected when queryInstances of this user reach 30000, and big queries that queryInstances more than 1000 should be rejected when queryInstances of this user reach 20000. Limiting rules like this will be complex and need to be modified at any time.
   
   So we add a config that support this feature, using `SpEL` to evaluate whether to limit a query or not. The limiting expressions will be reset at any time, and the `Expression` needed to be compile as soon as setting the config. This is what this pr for, I think more configs will need callback in the future.
   
   We are using 0.13 and #6159 is not supported yet. In master, there is a similar feature `sql block rule` #6192 which can support `query traffic limit`, maybe add a `limit` property. So I won't push our traffic limit pr to master, but just add config handler to support config setting callback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org