You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ba...@apache.org on 2010/03/29 12:03:20 UTC
svn commit: r928674 -
/james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/impl/BodyHasherImpl.java
Author: bago
Date: Mon Mar 29 10:03:19 2010
New Revision: 928674
URL: http://svn.apache.org/viewvc?rev=928674&view=rev
Log:
Make sure to validate the signature templates and throw PermFailException if an invalid template is provided (otherwise it was throwing NPE later)
Modified:
james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/impl/BodyHasherImpl.java
Modified: james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/impl/BodyHasherImpl.java
URL: http://svn.apache.org/viewvc/james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/impl/BodyHasherImpl.java?rev=928674&r1=928673&r2=928674&view=diff
==============================================================================
--- james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/impl/BodyHasherImpl.java (original)
+++ james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/impl/BodyHasherImpl.java Mon Mar 29 10:03:19 2010
@@ -47,6 +47,12 @@ public class BodyHasherImpl implements B
throw new PermFailException("Unsupported algorythm: "
+ sign.getHashAlgo(), e);
}
+
+ try {
+ sign.validate();
+ } catch (IllegalStateException e) {
+ throw new PermFailException("Invalid signature template", e);
+ }
int limit = sign.getBodyHashLimit();
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org