[GitHub] [incubator-flagon-useralejs] Jyyjy commented on pull request #323: Composed path

[GitBox <gi...@apache.org>]

Jyyjy commented on PR #323:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/323#issuecomment-1355412304

   > @Jyyjy -- are there follow ups to be potentially done [ in the future ,with more time ]?
   > 
   > Said another way: sounds like this addresses an urgent need, what cleanup/changes are worthy of consideration for cleanup?
   
   There's a few potential follow up changes I would make/suggest:
   
   1. The "defaults to path if available" testcase sets the path (or compossedPath() in my pr) to a value rather than testing the path that is generated by the dispatched event.
   2. initEvent(), which is used a few times throughout the testcases, is deprecated and should be replaced with event constructors.
   3. There's no need to manually build a path or for the "builds a path" testcase because composedPath() is universally supported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@flagon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org