You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/28 06:23:57 UTC
[GitHub] [spark] weixiuli opened a new pull request #35675: [SPARK-38344][SHUFFLE] Avoid to submit task when there are no requests to push up in push-based shuffle.
weixiuli opened a new pull request #35675:
URL: https://github.com/apache/spark/pull/35675
### What changes were proposed in this pull request?
Avoid to submit task when there are no requests to push up in push-based shuffle.
### Why are the changes needed?
This is a performance improvement to the existing functionality.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GA.
Existing unittests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #35675: [SPARK-38344][SHUFFLE] Avoid to submit task when there are no requests to push up in push-based shuffle.
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #35675:
URL: https://github.com/apache/spark/pull/35675#issuecomment-1056068119
Merged to master.
Thanks for fixing this @weixiuli !
Thanks for the review @zhouyejoe :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhouyejoe commented on pull request #35675: [SPARK-38344][SHUFFLE] Avoid to submit task when there are no requests to push up in push-based shuffle.
Posted by GitBox <gi...@apache.org>.
zhouyejoe commented on pull request #35675:
URL: https://github.com/apache/spark/pull/35675#issuecomment-1055098792
Reasonable change. Thanks for making the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35675: [SPARK-38344][SHUFFLE] Avoid to submit task when there are no requests to push up in push-based shuffle.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35675:
URL: https://github.com/apache/spark/pull/35675#issuecomment-1054976982
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #35675: [SPARK-38344][SHUFFLE] Avoid to submit task when there are no requests to push up in push-based shuffle.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #35675:
URL: https://github.com/apache/spark/pull/35675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org