You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joel Koshy <jj...@gmail.com> on 2014/06/12 01:18:16 UTC
Review Request 22482: Patch for KAFKA-1491
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22482/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1491
https://issues.apache.org/jira/browse/KAFKA-1491
Repository: kafka
Description
-------
Always read coordinator information in consumer metadata response
Diffs
-----
core/src/main/scala/kafka/api/ConsumerMetadataResponse.scala f8cf6c326d7dab001f21caa8bb0f20900b2090b1
core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d
Diff: https://reviews.apache.org/r/22482/diff/
Testing
-------
Thanks,
Joel Koshy
Re: Review Request 22482: Patch for KAFKA-1491
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22482/#review45838
-----------------------------------------------------------
Ship it!
Have a minor review comment
core/src/main/scala/kafka/client/ClientUtils.scala
<https://reviews.apache.org/r/22482/#comment80830>
It seems this is appropriate at the debug level, instead of info.
- Neha Narkhede
On June 11, 2014, 11:18 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22482/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 11:18 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1491
> https://issues.apache.org/jira/browse/KAFKA-1491
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Always read coordinator information in consumer metadata response
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/ConsumerMetadataResponse.scala f8cf6c326d7dab001f21caa8bb0f20900b2090b1
> core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d
>
> Diff: https://reviews.apache.org/r/22482/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 22482: Patch for KAFKA-1491
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22482/#review45456
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On June 11, 2014, 11:18 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22482/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 11:18 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1491
> https://issues.apache.org/jira/browse/KAFKA-1491
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Always read coordinator information in consumer metadata response
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/ConsumerMetadataResponse.scala f8cf6c326d7dab001f21caa8bb0f20900b2090b1
> core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d
>
> Diff: https://reviews.apache.org/r/22482/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>