You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mathias Weinert <ma...@gfa-net.de> on 2006/01/02 10:04:22 UTC
Re: [PATCH] improved svnadmin hotcopy help
Hi there,
first of all: Happy New Year!!!
second: Congratulations for shipping release 1.3.0! (although
at the moment there are some problems with the download ;-) )
I sent a little patch some days ago and didn't get any response.
As 1.3.0 is out now I hope to get any comment about this patch.
please find the original mail below.
Mathias
Original mail:
> Hi there,
>
> please find enclosed a little patch which clearifys the help for
> the 'clean-logs' option for 'svnadmin hotcopy'.
>
> Mathias
[[[
* subversion/svnadmin/main.c
- clearified help for the 'clean-logs' option for 'svnadmin hotcopy'
]]]
--- subversion/svnadmin/main.c.orig 2005-08-28 00:26:20.000000000 +0200
+++ subversion/svnadmin/main.c 2005-12-27 10:28:39.232833400 +0100
@@ -270,7 +270,9 @@
N_("read user configuration files from directory ARG")},
{"clean-logs", svnadmin__clean_logs, 0,
- N_("remove redundant log files from source repository")},
+ N_("remove redundant Berkeley DB log files\n"
+ " "
+ "from source repository [Berkeley DB]")},
{"use-pre-commit-hook", svnadmin__use_pre_commit_hook, 0,
N_("call pre-commit hook before committing revisions")},
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] improved svnadmin hotcopy help
Posted by Julian Foad <ju...@btopenworld.com>.
Malcolm Rowe wrote:
>
> The other BDB options have 'bdb'
> in their names though, so it's fairly obvious that they apply to BDB
> repositories only, IMO.
Oh yes; I hadn't spotted that.
> Do you think it'd be clearer if I removed the first instance of 'Berkeley
> DB' from the text? Or not worth bothering?
Not worth bothering, then, I think. It's good as it is.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] improved svnadmin hotcopy help
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Sat, Jan 14, 2006 at 01:52:59AM +0000, Julian Foad wrote:
> >>Thanks for the patch... it looks fine to me. It makes the help text
> >>consistent with other help text that refers to "Berkeley DB log files"
> >>(list-dblogs and list-unused-dblogs).
>
> ... but inconsistent with the other _option_ that refers to log files:
>
Hmm, you're right. I didn't see the BDB options on 'svnadmin create'.
> {"bdb-log-keep", svnadmin__bdb_log_keep, 0,
> N_("disable automatic log file removal [Berkeley DB]")},
>
> Malcolm Rowe wrote:
> >Committed as r18097, with a little tweaking
>
> > {"clean-logs", svnadmin__clean_logs, 0,
> >- N_("remove redundant log files from source repository")},
> >+ N_("remove redundant Berkeley DB log files\n"
>
> Like with bdb-log-keep, there's no need to mention "Berkeley DB" there...
>
> >+ " from source repository [Berkeley
> >DB]")},
>
> ... when it's mentioned there. But it's not doing any harm and removal
> wouldn't create enough space to fit it onto one output line.
>
Yes, I wasn't really happy with the duplication either, though it seemed
to make sense given the arguments. The other BDB options have 'bdb'
in their names though, so it's fairly obvious that they apply to BDB
repositories only, IMO.
Do you think it'd be clearer if I removed the first instance of 'Berkeley
DB' from the text? Or not worth bothering?
Thanks for the review, anyway.
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] improved svnadmin hotcopy help
Posted by Julian Foad <ju...@btopenworld.com>.
> On Fri, Jan 13, 2006 at 10:31:19AM -0700, Michael W Thelen wrote:
>
>>Thanks for the patch... it looks fine to me. It makes the help text
>>consistent with other help text that refers to "Berkeley DB log files"
>>(list-dblogs and list-unused-dblogs).
... but inconsistent with the other _option_ that refers to log files:
{"bdb-log-keep", svnadmin__bdb_log_keep, 0,
N_("disable automatic log file removal [Berkeley DB]")},
Malcolm Rowe wrote:
> Committed as r18097, with a little tweaking
> {"clean-logs", svnadmin__clean_logs, 0,
> - N_("remove redundant log files from source repository")},
> + N_("remove redundant Berkeley DB log files\n"
Like with bdb-log-keep, there's no need to mention "Berkeley DB" there...
> + " from source repository [Berkeley DB]")},
... when it's mentioned there. But it's not doing any harm and removal
wouldn't create enough space to fit it onto one output line.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] improved svnadmin hotcopy help
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Fri, Jan 13, 2006 at 10:31:19AM -0700, Michael W Thelen wrote:
> Thanks for the patch... it looks fine to me. It makes the help text
> consistent with other help text that refers to "Berkeley DB log files"
> (list-dblogs and list-unused-dblogs). And the "[Berkeley DB]" notation
> is consistent with the "svnadmin create" help text, which also uses it
> for BDB-specific options. Would a full committer be willing to commit
> this or +1 it? If there is no response within a day or two, I'll file
> an issue for it in the issue tracker.
>
Committed as r18097, with a little tweaking (original patch wouldn't
apply properly, and I saw no reason to break the second line into two).
Thanks!
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] improved svnadmin hotcopy help
Posted by Michael W Thelen <mi...@pietdepsi.com>.
Mathias Weinert wrote:
> I sent a little patch some days ago and didn't get any response.
> As 1.3.0 is out now I hope to get any comment about this patch.
>
> please find the original mail below.
Thanks for the patch... it looks fine to me. It makes the help text
consistent with other help text that refers to "Berkeley DB log files"
(list-dblogs and list-unused-dblogs). And the "[Berkeley DB]" notation
is consistent with the "svnadmin create" help text, which also uses it
for BDB-specific options. Would a full committer be willing to commit
this or +1 it? If there is no response within a day or two, I'll file
an issue for it in the issue tracker.
> [[[
> * subversion/svnadmin/main.c
> - clearified help for the 'clean-logs' option for 'svnadmin hotcopy'
> ]]]
>
> --- subversion/svnadmin/main.c.orig 2005-08-28 00:26:20.000000000 +0200
> +++ subversion/svnadmin/main.c 2005-12-27 10:28:39.232833400 +0100
> @@ -270,7 +270,9 @@
> N_("read user configuration files from directory ARG")},
>
> {"clean-logs", svnadmin__clean_logs, 0,
> - N_("remove redundant log files from source repository")},
> + N_("remove redundant Berkeley DB log files\n"
> + " "
> + "from source repository [Berkeley DB]")},
>
> {"use-pre-commit-hook", svnadmin__use_pre_commit_hook, 0,
> N_("call pre-commit hook before committing revisions")},
--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes. -- Douglas Adams
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org