You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/21 11:23:22 UTC

[GitHub] [shardingsphere] tristaZero commented on pull request #10889: Convert ss ast to calcite ast

tristaZero commented on pull request #10889:
URL: https://github.com/apache/shardingsphere/pull/10889#issuecomment-864955327


   Hi @guimingyue ,
   
   That's exactly for our first step. The content is fine with me, but I assume we need an `engine` or `mechanism` to do converting work. 
   Instead of `all in one`, I prefer splitting `sqlNodeConverter` into many child ones, each of which just focuses its function and avoids interfering with others. 
   I just raised a #10895 to help us do such things. How do you think? It is possible to fill #10895 with what you did in this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org