You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Carlos Sanchez (JIRA)" <ji...@codehaus.org> on 2006/03/30 12:26:44 UTC
[jira] Created: (MRELEASE-87) Poms are written with wrong encodings
Poms are written with wrong encodings
-------------------------------------
Key: MRELEASE-87
URL: http://jira.codehaus.org/browse/MRELEASE-87
Project: Maven 2.x Release Plugin
Type: Bug
Versions: 2.0-beta-4
Reporter: Carlos Sanchez
Priority: Critical
Fix For: 2.0-beta-4
I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-87) Poms are written with wrong
encodings
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112389 ]
Herve Boutemy commented on MRELEASE-87:
---------------------------------------
everything should be fixed in r591123
but I didn't find your test (testWritePom in PrepareReleaseMojoTest) to check it
I think I'll write 2 sets of POM files:
- src/test/resources/rewrite-for-development/basic-pom-with-encoding
- src/test/resources/rewrite-for-release/basic-pom-with-encoding
like basic-pom ones, but with poms in UTF-16: I guarantee it will fail if encoding isn't properly handled somewhere :)
but I need some time to understand the coding part of the tests
any idea on other useful tests?
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-4, 2.0-beta-5, 2.0-beta-6
> Reporter: Carlos Sanchez
> Assignee: Herve Boutemy
> Priority: Critical
> Fix For: 2.0-beta-8
>
> Attachments: MRELEASE-87-bis.diff, MRELEASE-87.diff
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MRELEASE-87) Poms are written with
wrong encodings
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103719 ]
Herve Boutemy edited comment on MRELEASE-87 at 8/1/07 1:22 AM:
---------------------------------------------------------------
Here is a patch to use WriterFactory and XmlStreamWriter added in plexus-utils 1.4.5 to handle stream encoding detection according to the XML content written.
see http://docs.codehaus.org/display/MAVENUSER/XML+encoding for the roadmap to XML encoding support in Maven2
was:
Here is a patch to use WriterFactory and XmlStreamWriter added in plexus-utils 1.4.5 to handle stream encoding detection according to the XML content written
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-4, 2.0-beta-5, 2.0-beta-6
> Reporter: Carlos Sanchez
> Priority: Critical
> Fix For: 2.0-beta-7
>
> Attachments: MRELEASE-87.diff
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-87) Poms are written with wrong encodings
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MRELEASE-87:
----------------------------------
Affects Version/s: 2.0-beta-5
2.0-beta-6
Fix Version/s: 2.0-beta-7
Patch Submitted: [Yes]
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-4, 2.0-beta-5, 2.0-beta-6
> Reporter: Carlos Sanchez
> Priority: Critical
> Fix For: 2.0-beta-7
>
> Attachments: MRELEASE-87.diff
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRELEASE-87) Poms are written with wrong encodings
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy closed MRELEASE-87.
---------------------------------
Resolution: Fixed
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-4, 2.0-beta-5, 2.0-beta-6
> Reporter: Carlos Sanchez
> Assignee: Herve Boutemy
> Priority: Critical
> Fix For: 2.0-beta-8
>
> Attachments: MRELEASE-87-bis.diff, MRELEASE-87.diff
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-87) Poms are written with wrong encodings
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MRELEASE-87:
----------------------------------
Attachment: MRELEASE-87.diff
Here is a patch to use WriterFactory and XmlStreamWriter added in plexus-utils 1.4.5 to handle stream encoding detection according to the XML content written
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-4, 2.0-beta-5, 2.0-beta-6
> Reporter: Carlos Sanchez
> Priority: Critical
> Fix For: 2.0-beta-7
>
> Attachments: MRELEASE-87.diff
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-87) Poms are written with wrong
encodings
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=comments#action_64137 ]
Carlos Sanchez commented on MRELEASE-87:
----------------------------------------
I wrote a test, testWritePom in PrepareReleaseMojoTest
i have commented it because it succeeds under win and fails on linux continuum and
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Type: Bug
> Versions: 2.0-beta-4
> Reporter: Carlos Sanchez
> Priority: Critical
> Fix For: 2.0-beta-4
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-87) Poms are written with wrong
encodings
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=comments#action_64138 ]
Carlos Sanchez commented on MRELEASE-87:
----------------------------------------
and don't have time to test right now
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Type: Bug
> Versions: 2.0-beta-4
> Reporter: Carlos Sanchez
> Priority: Critical
> Fix For: 2.0-beta-4
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-87) Poms are written with wrong
encodings
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_120930 ]
Mark Hobson commented on MRELEASE-87:
-------------------------------------
The AbstractRewritingReleasePhaseTestCase.testRewriteBasicPomWithEncoding test committed for this issue (r595973) breaks under Windows due to line-endings. This is because AbstractRewritePomsPhase uses native EOL endings whereas the basic-pom-with-encoding expected POM uses LF EOL endings. All other expected POMs use native EOL endings.
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-4, 2.0-beta-5, 2.0-beta-6
> Reporter: Carlos Sanchez
> Assignee: Herve Boutemy
> Priority: Critical
> Fix For: 2.0-beta-8
>
> Attachments: MRELEASE-87-bis.diff, MRELEASE-87.diff
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-87) Poms are written with wrong
encodings
Posted by "Joerg Schaible (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=comments#action_63919 ]
Joerg Schaible commented on MRELEASE-87:
----------------------------------------
JIRA did some own interpretation of the last comment, so the name of the developer contained originally:
{noformat}
<name>ö ö €</name>
{noformat}
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Type: Bug
> Versions: 2.0-beta-4
> Reporter: Carlos Sanchez
> Priority: Critical
> Fix For: 2.0-beta-4
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-87) Poms are written with wrong encodings
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MRELEASE-87:
----------------------------------
Attachment: MRELEASE-87-bis.diff
ok, reworked the patch: the unreleased dependency was a typo (how could I let it into the patch?...)
but one problem persists when running testcases that I cannot find how to fix:
{{org.codehaus.plexus.component.repository.exception.ComponentLookupException: Component descriptor cannot be found in the component repository: org.apache.maven.artifact.metadata.ArtifactMetadataSource [default] (lookup realm: ClassRealm[plexus.core, parent: null]).}}
:(
it contains a little fix for a problem committed this morning in r567988 for MRELEASE-124: String.contains API is only available in Java 5+, it is not in Java 1.4
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-4, 2.0-beta-5, 2.0-beta-6
> Reporter: Carlos Sanchez
> Priority: Critical
> Fix For: 2.0-beta-7
>
> Attachments: MRELEASE-87-bis.diff, MRELEASE-87.diff
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-87) Poms are written with wrong encodings
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=all ]
Brett Porter updated MRELEASE-87:
---------------------------------
Fix Version: (was: 2.0-beta-4)
2.0
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Type: Bug
> Versions: 2.0-beta-4
> Reporter: Carlos Sanchez
> Priority: Critical
> Fix For: 2.0
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-87) Poms are written with wrong encodings
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MRELEASE-87:
------------------------------
Fix Version/s: (was: 2.0-beta-7)
2.0-beta-8
we need to push a release of beta-7 to do a release of 2.0.8. Bumping to next release
> Poms are written with wrong encodings
> -------------------------------------
>
> Key: MRELEASE-87
> URL: http://jira.codehaus.org/browse/MRELEASE-87
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-4, 2.0-beta-5, 2.0-beta-6
> Reporter: Carlos Sanchez
> Priority: Critical
> Fix For: 2.0-beta-8
>
> Attachments: MRELEASE-87-bis.diff, MRELEASE-87.diff
>
>
> I have committed a test that works in my Sun and IBM JDKs under windows but breaks in the Continuum at codehaus.
> Tomorrow i'll try with IBM JDK under linux.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira