You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/04 04:04:53 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3029: [Bug]
Fix bug of NPE when get replication number from olap table
morningman opened a new pull request #3029: [Bug] Fix bug of NPE when get replication number from olap table
URL: https://github.com/apache/incubator-doris/pull/3029
The default replication number of an olap table may not be set.
Every time we call `getReplicationNum()`, we have to check if it returns null,
which is inconvenience and may cause problem
So in this PR, I set a default value to table's replication number.
This bug is introduced by #2958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3029: [Bug] Fix
bug of NPE when get replication number from olap table
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3029: [Bug] Fix bug of NPE when get replication number from olap table
URL: https://github.com/apache/incubator-doris/pull/3029
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request
#3029: [Bug] Fix bug of NPE when get replication number from olap table
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #3029: [Bug] Fix bug of NPE when get replication number from olap table
URL: https://github.com/apache/incubator-doris/pull/3029#discussion_r388058874
##########
File path: fe/src/main/java/org/apache/doris/catalog/OlapTable.java
##########
@@ -1247,11 +1248,11 @@ public void setReplicationNum(Short replicationNum) {
tableProperty.buildReplicationNum();
}
- public Short getReplicationNum() {
+ public Short getDefaultReplicationNum() {
Review comment:
Is `getReplicationNum ` better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org