[GitHub] [hive] saihemanth-cloudera commented on a diff in pull request #4164: HIVE-27179: HS2 WebUI throws NPE when JspFactory loaded from jetty-runner

["saihemanth-cloudera (via GitHub)" <gi...@apache.org>]

saihemanth-cloudera commented on code in PR #4164:
URL: https://github.com/apache/hive/pull/4164#discussion_r1152709966


##########
service/src/java/org/apache/hive/service/server/HiveServer2.java:
##########
@@ -133,6 +133,8 @@
 import com.google.common.util.concurrent.SettableFuture;
 import com.google.common.util.concurrent.ThreadFactoryBuilder;
 
+import javax.servlet.jsp.JspFactory;

Review Comment:
   I see that you have removed javax.servlet dependency from root and service's pom.xml. I'm wondering where this dependency is coming from.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org