You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2020/07/10 10:05:40 UTC
Review Request 72669: ATLAS-3888 : BasicSearch: Multiple type/tag:
[Regression], Restrict when tag filters and regex in tag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72669/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3888
https://issues.apache.org/jira/browse/ATLAS-3888
Repository: atlas
Description
-------
**Issue:**
In Basic search ,
tag : PII_*
tag filter : sensitivity < 0.5
returns 200 OK with no entities in response though there are entities tagged with PII_1 with sensitivity < 0.5
**Expected:** 400 Bad request , as tag filters are not allowed when the tag has regex.
**Note:** This patch will only resolve tags having regex Eg. "PII_*" not "*", * can have System attribute filters.
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/SearchContext.java dd24a8cc4
Diff: https://reviews.apache.org/r/72669/diff/1/
Testing
-------
Manually Tested
Precommit :
Thanks,
Pinal Shah
Re: Review Request 72669: ATLAS-3888 : BasicSearch: Multiple type/tag:
[Regression], Restrict when tag filters and regex in tag
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72669/#review221190
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 10, 2020, 10:05 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72669/
> -----------------------------------------------------------
>
> (Updated July 10, 2020, 10:05 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3888
> https://issues.apache.org/jira/browse/ATLAS-3888
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Issue:**
> In Basic search ,
> tag : PII_*
> tag filter : sensitivity < 0.5
> returns 200 OK with no entities in response though there are entities tagged with PII_1 with sensitivity < 0.5
>
> **Expected:** 400 Bad request , as tag filters are not allowed when the tag has regex.
>
> **Note:** This patch will only resolve tags having regex Eg. 'PII_*' not '*', because it can have System attribute filters.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/SearchContext.java dd24a8cc4
>
>
> Diff: https://reviews.apache.org/r/72669/diff/2/
>
>
> Testing
> -------
>
> Manually Tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2039/
>
>
> Thanks,
>
> Pinal Shah
>
>