You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "zstan (via GitHub)" <gi...@apache.org> on 2023/09/06 08:52:22 UTC

[GitHub] [ignite-3] zstan commented on a diff in pull request #2552: IGNITE-19106 Sql. Fix partially broken column namings

zstan commented on code in PR #2552:
URL: https://github.com/apache/ignite-3/pull/2552#discussion_r1316954930


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientSqlTest.java:
##########
@@ -213,8 +213,7 @@ void testExecuteAsyncDdlDml() throws InterruptedException {
         assertEquals(3, columns.size());
         assertEquals("MYVALUE", columns.get(0).name());
         assertEquals("ID", columns.get(1).name());
-        // TODO: Uncomment after https://issues.apache.org/jira/browse/IGNITE-19106 Column namings are partially broken
-        //assertEquals("ID + 1", columns.get(2).name());
+        assertEquals("TESTEXECUTEASYNCDDLDML.ID + 1", columns.get(2).name());

Review Comment:
   incorrect in comparison with what ? there is no standard for this case as i know, we can use here all we want and additional table name is a bit informative, why not ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org