You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by prestona <gi...@git.apache.org> on 2015/05/19 00:18:53 UTC

[GitHub] qpid-proton pull request: PROTON-881: make unittests check for Jav...

GitHub user prestona opened a pull request:

    https://github.com/apache/qpid-proton/pull/31

    PROTON-881: make unittests check for Java I/O object leaks

    This implements an interface which is similar to pn_io - so that the various Java I/O resources (e.g. Selector, Pipe, SocketChannel, and ServerSocketChannel) are all created in a single place.  
    
    The new IO interface is used by a new test class: LeakTestReactor to extend ReactorImpl with logic for detecting when a Java I/O resource is _not_ closed by a testcase.
    
    The Reactor unit tests have been parameterized to run once with the reactor implementation returned from Proton.reactor() and once with the LeakTestReactor test class.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prestona/qpid-proton reactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 2d3cefc4562e2246a9007d500cf2885ad9b8adc6
Author: Adrian Preston <pr...@uk.ibm.com>
Date:   2015-05-18T22:07:22Z

    PROTON-881: make unittests check for Java I/O object leaks
    
    Implements something similar to pn_io so that the various Java I/O resources are
    created in a single place.  Reactor unit tests are parameterized to run once with
    the reactor implementation returned from Proton.reactor() and once from a
    unittest extension of ReactorImpl which checks that all Java I/O resources, used
    by testcase, are closed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] qpid-proton pull request: PROTON-881: make unittests check for Jav...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/qpid-proton/pull/31


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---