You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/28 21:55:15 UTC
[GitHub] [beam] fernando-wizeline opened a new pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
fernando-wizeline opened a new pull request #15611:
URL: https://github.com/apache/beam/pull/15611
Hitting the "copy to clipboard" button copies the snippet with all the html formatting.
By using the innerText instead of the innerHTML property, we were able to get the actual text without the HTML code.
@pabloem is this something you can help me to review?
Thanks!
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
`ValidatesRunner` compliance status (on master branch)
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Examples testing status on various runners
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
Post-Commit SDK/Transform Integration Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Go</th>
<th>Java</th>
<th>Python</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
</a>
</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15611:
URL: https://github.com/apache/beam/pull/15611#issuecomment-931406005
> @fernando-wizeline Well, I guess it would be easier to re-create your feature branch (`fernando-wizeline:BEAM-12607`) from current `master`, commit your changes into this branch and push it again.
Great! Thanks for the suggestion @aromanenko-dev!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15611:
URL: https://github.com/apache/beam/pull/15611#issuecomment-930628926
> Thanks for the fix, @fernando-wizeline ! I tested with [staged version ](http://apache-beam-website-pull-requests.storage.googleapis.com/15611/documentation/runners/dataflow/index.html) and it works for me on Mac.
>
> In the same time, could you avoid merge commits and just rebase your feature branch with a fix commit on top of `master` branch? Thanks!
Hi @aromanenko-dev ! I'm trying to squash my commits, but the commits displayed here and the ones shown in my local branch differ by 5 "Merge branch 'apache:master' into master" commits. I see six here while in my local branch I see only one.
Any idea what might be occurring?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718128914
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
should we leave this alert here? is there a less intrusive way of noting that things have been copied? the alert requires you to accept, which is kind of annoying...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15611:
URL: https://github.com/apache/beam/pull/15611#issuecomment-930557151
Agreed to remove! Thanks.
On Wed, Sep 29, 2021, 11:10 AM Alexey Romanenko ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In website/www/site/static/js/copy-to-clipboard.js
> <https://github.com/apache/beam/pull/15611#discussion_r718724103>:
>
> > @@ -13,15 +13,15 @@
> $(document).ready(function() {
> function copy() {
> $(".copy").click(function(){
> - var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
> + var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
> const el=document.createElement('textarea');
> el.value=text;document.body.appendChild(el);
> el.select();document.execCommand('copy');
> document.body.removeChild(el);
> alert('copied to clipboard');
>
> +1 to remove it. @pabloem <https://github.com/pabloem>, wdyt?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/15611#discussion_r718724103>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJ5Z3BIZC4KGTDTR4RPJQLUENCAJANCNFSM5E6NB7ZQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #15611:
URL: https://github.com/apache/beam/pull/15611#issuecomment-931387051
@fernando-wizeline Well, I guess it would be easier to re-create your feature branch (`fernando-wizeline:BEAM-12607`) from current `master`, commit your changes into this branch and push it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a change in pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718312765
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
Agree with @pabloem. Do we need this alert at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a change in pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718858248
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
@pabloem I went ahead and submitted the change.
Please let me know if you have further comments!
Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a change in pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718722958
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
Thanks for the feedback @pabloem and @aromanenko-dev !
Based on your inputs, Is it ok if I remove both alerts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a change in pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718724103
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
+1 to remove it. @pabloem, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a change in pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718312765
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
Agree with @pabloem. Do we need this alert at all?
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
+1 to remove it. @pabloem, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline closed pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
fernando-wizeline closed pull request #15611:
URL: https://github.com/apache/beam/pull/15611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on pull request #15611:
URL: https://github.com/apache/beam/pull/15611#issuecomment-930628926
> Thanks for the fix, @fernando-wizeline ! I tested with [staged version ](http://apache-beam-website-pull-requests.storage.googleapis.com/15611/documentation/runners/dataflow/index.html) and it works for me on Mac.
>
> In the same time, could you avoid merge commits and just rebase your feature branch with a fix commit on top of `master` branch? Thanks!
Hi @aromanenko-dev ! I'm trying to squash my commits, but the commits displayed here and the ones shown in my local branch differ by 5 "Merge branch 'apache:master' into master" commits. I see six here while in my local branch I see only one.
Any idea what might be occurring?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15611:
URL: https://github.com/apache/beam/pull/15611#issuecomment-930557151
Agreed to remove! Thanks.
On Wed, Sep 29, 2021, 11:10 AM Alexey Romanenko ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In website/www/site/static/js/copy-to-clipboard.js
> <https://github.com/apache/beam/pull/15611#discussion_r718724103>:
>
> > @@ -13,15 +13,15 @@
> $(document).ready(function() {
> function copy() {
> $(".copy").click(function(){
> - var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
> + var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
> const el=document.createElement('textarea');
> el.value=text;document.body.appendChild(el);
> el.select();document.execCommand('copy');
> document.body.removeChild(el);
> alert('copied to clipboard');
>
> +1 to remove it. @pabloem <https://github.com/pabloem>, wdyt?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/15611#discussion_r718724103>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJ5Z3BIZC4KGTDTR4RPJQLUENCAJANCNFSM5E6NB7ZQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718128914
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
should we leave this alert here? is there a less intrusive way of noting that things have been copied? the alert requires you to accept, which is kind of annoying...
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
same for the alert on line 29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a change in pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718722958
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
Thanks for the feedback @pabloem and @aromanenko-dev !
Based on your inputs, Is it ok if I remove both alerts?
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
@pabloem I went ahead and submitted the change.
Please let me know if you have further comments!
Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15611: [BEAM-12607] - Copy Code Snippet copies html tags
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718129111
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
same for the alert on line 29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org