You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "foxtail463 (via GitHub)" <gi...@apache.org> on 2026/01/28 09:42:00 UTC
[PR] [fix](dictionary): use correct property key when parsing memory_limi… [doris]
foxtail463 opened a new pull request, #60309:
URL: https://github.com/apache/doris/pull/60309
…t in CreateDictionaryInfo
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](dictionary): use correct property key when parsing memory_limit in CreateDictionaryInfo(#60306) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60309:
URL: https://github.com/apache/doris/pull/60309#issuecomment-3833474712
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60309_2870dca3346461535ddee42e51afe2b9b64ee530_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60309_2870dca3346461535ddee42e51afe2b9b64ee530_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](dictionary): use correct property key when parsing memory_limit in CreateDictionaryInfo(#60306) [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #60309:
URL: https://github.com/apache/doris/pull/60309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](dictionary): use correct property key when parsing memory_limi… [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60309:
URL: https://github.com/apache/doris/pull/60309#issuecomment-3810140059
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](dictionary): use correct property key when parsing memory_limit in CreateDictionaryInfo(#60306) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60309:
URL: https://github.com/apache/doris/pull/60309#issuecomment-3832829751
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](dictionary): use correct property key when parsing memory_limit in CreateDictionaryInfo(#60306) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #60309:
URL: https://github.com/apache/doris/pull/60309#issuecomment-3832827218
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](dictionary): use correct property key when parsing memory_limit in CreateDictionaryInfo(#60306) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60309:
URL: https://github.com/apache/doris/pull/60309#issuecomment-3832887650
<details>
<summary>TPC-H: <b>Total hot run time: 32060 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2870dca3346461535ddee42e51afe2b9b64ee530, data reload: false
------ Round 1 ----------------------------------
q1 17636 5315 5078 5078
q2 2088 313 198 198
q3 10150 1297 716 716
q4 10210 847 308 308
q5 7505 2151 1877 1877
q6 195 180 145 145
q7 892 730 614 614
q8 9250 1372 1106 1106
q9 5104 4844 4876 4844
q10 6798 1951 1549 1549
q11 523 292 284 284
q12 345 382 226 226
q13 17759 4049 3248 3248
q14 231 231 214 214
q15 885 829 802 802
q16 686 675 610 610
q17 629 808 475 475
q18 6724 6553 7454 6553
q19 1275 1106 646 646
q20 417 365 254 254
q21 2983 2312 2033 2033
q22 372 326 280 280
Total cold run time: 102657 ms
Total hot run time: 32060 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5599 5574 5583 5574
q2 276 349 266 266
q3 2431 2862 2464 2464
q4 1444 1769 1504 1504
q5 4721 4573 4502 4502
q6 216 183 139 139
q7 2063 1918 1752 1752
q8 2528 2558 2473 2473
q9 7461 7869 7369 7369
q10 3017 3045 2592 2592
q11 531 478 443 443
q12 739 722 610 610
q13 3858 4219 3606 3606
q14 299 314 300 300
q15 906 863 807 807
q16 662 710 646 646
q17 1066 1202 1216 1202
q18 7459 7515 7396 7396
q19 798 792 785 785
q20 1961 2050 1870 1870
q21 4460 4200 4199 4199
q22 560 544 510 510
Total cold run time: 53055 ms
Total hot run time: 51009 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](dictionary): use correct property key when parsing memory_limit in CreateDictionaryInfo(#60306) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60309:
URL: https://github.com/apache/doris/pull/60309#issuecomment-3832829660
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](dictionary): use correct property key when parsing memory_limit in CreateDictionaryInfo(#60306) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60309:
URL: https://github.com/apache/doris/pull/60309#issuecomment-3832924168
<details>
<summary>ClickBench: <b>Total hot run time: 28.06 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2870dca3346461535ddee42e51afe2b9b64ee530, data reload: false
query1 0.06 0.05 0.05
query2 0.11 0.05 0.05
query3 0.27 0.09 0.08
query4 1.60 0.10 0.11
query5 0.27 0.25 0.27
query6 1.17 0.68 0.67
query7 0.03 0.03 0.03
query8 0.05 0.04 0.04
query9 0.56 0.51 0.50
query10 0.56 0.55 0.54
query11 0.14 0.10 0.10
query12 0.14 0.11 0.10
query13 0.62 0.60 0.62
query14 1.07 1.08 1.05
query15 0.87 0.87 0.87
query16 0.39 0.39 0.41
query17 1.14 1.09 1.14
query18 0.22 0.20 0.20
query19 2.09 2.04 1.92
query20 0.02 0.01 0.01
query21 15.40 0.30 0.14
query22 5.11 0.05 0.05
query23 15.88 0.29 0.10
query24 0.97 0.75 0.21
query25 0.05 0.07 0.06
query26 0.14 0.13 0.12
query27 0.07 0.08 0.07
query28 3.97 1.14 0.96
query29 12.56 3.92 3.11
query30 0.28 0.13 0.12
query31 2.81 0.65 0.40
query32 3.24 0.59 0.50
query33 3.26 3.23 3.24
query34 16.19 5.40 4.71
query35 4.86 4.91 4.78
query36 0.66 0.49 0.50
query37 0.11 0.07 0.07
query38 0.08 0.04 0.05
query39 0.04 0.02 0.02
query40 0.19 0.16 0.16
query41 0.09 0.04 0.03
query42 0.04 0.03 0.02
query43 0.05 0.03 0.04
Total cold run time: 97.43 s
Total hot run time: 28.06 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org