You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by ep...@apache.org on 2019/05/03 16:36:38 UTC

[hadoop] branch branch-2.8 updated: YARN-9285: RM UI progress column is of wrong type. Contributed by Ahmed Hussein.

This is an automated email from the ASF dual-hosted git repository.

epayne pushed a commit to branch branch-2.8
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/branch-2.8 by this push:
     new 93df928  YARN-9285: RM UI progress column is of wrong type. Contributed by  Ahmed Hussein.
93df928 is described below

commit 93df9287f3911d51d3d8de19e2ec4e9f1a6f971c
Author: Eric E Payne <er...@verizonmedia.com>
AuthorDate: Fri May 3 16:31:35 2019 +0000

    YARN-9285: RM UI progress column is of wrong type. Contributed by  Ahmed Hussein.
---
 .../hadoop/yarn/server/webapp/WebPageUtils.java    | 24 ++++++++++++++--------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/WebPageUtils.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/WebPageUtils.java
index 7586046..1d9f9aa 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/WebPageUtils.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/WebPageUtils.java
@@ -47,21 +47,27 @@ public class WebPageUtils {
 
   private static String getAppsTableColumnDefs(
       boolean isFairSchedulerPage, boolean isResourceManager) {
+    // default progress column index is 10
+    String progressIndex = "[10]";
     StringBuilder sb = new StringBuilder();
     sb.append("[\n")
       .append("{'sType':'natural', 'aTargets': [0]")
       .append(", 'mRender': parseHadoopID }")
       .append("\n, {'sType':'numeric', 'aTargets': [6, 7]")
-      .append(", 'mRender': renderHadoopDate }")
-      .append("\n, {'sType':'num-ignore-str', 'aTargets': [10, 11, 12] }")
-      .append("\n, {'sType':'numeric', bSearchable:false, 'aTargets':");
-    if (isFairSchedulerPage) {
-      sb.append("[13]");
-    } else if (isResourceManager) {
-      sb.append("[15]");
-    } else {
-      sb.append("[9]");
+      .append(", 'mRender': renderHadoopDate }");
+    if (isResourceManager) {
+      // Update following line if any column added in RM page before column 10
+      sb.append("\n, {'sType':'num-ignore-str', 'aTargets': [10, 11, 12] }");
+      // set progress column index to 15
+      progressIndex = "[15]";
+    } else if (isFairSchedulerPage) {
+      // Update following line if any column added in scheduler page before column 10
+      sb.append("\n, {'sType':'num-ignore-str', 'aTargets': [10, 11, 12] }");
+      // set progress column index to 13
+      progressIndex = "[13]";
     }
+    sb.append("\n, {'sType':'numeric', bSearchable:false, 'aTargets':");
+    sb.append(progressIndex);
     sb.append(", 'mRender': parseHadoopProgress }]");
     return sb.toString();
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org