You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/28 22:18:51 UTC
[GitHub] [hbase] saintstack opened a new pull request #1103: HBASE-23753
Update of errorprone generated failures
saintstack opened a new pull request #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103
hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
Complains about mismatch in types when Compare. Implement Compare in
base Interface.
hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
Complains pbs never return null.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSinkManager.java
Needed redo because errorprone complains can't mock Service from guava.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicasWithRestartScenarios.java
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestSnapshotScannerHDFSAclController.java
Unrelated...adding one-liner debug statements chasing other test
failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1103:
HBASE-23753 Update of errorprone generated failures
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#discussion_r372134724
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
##########
@@ -18,6 +18,7 @@
*/
package org.apache.hadoop.hbase.executor;
+import java.awt.*;
Review comment:
Mistake. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1103:
HBASE-23753 Update of errorprone generated failures
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#discussion_r372135010
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSinkManager.java
##########
@@ -65,12 +90,8 @@ public void testChooseSinks() {
for (int i = 0; i < totalServers; i++) {
serverNames.add(mock(ServerName.class));
}
-
- when(replicationEndpoint.getRegionServers())
- .thenReturn(serverNames);
-
+ this.replicationEndpoint.setRegionServers(serverNames);
Review comment:
Will change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1103:
HBASE-23753 Update of errorprone generated failures
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#discussion_r372133413
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSinkManager.java
##########
@@ -65,12 +90,8 @@ public void testChooseSinks() {
for (int i = 0; i < totalServers; i++) {
serverNames.add(mock(ServerName.class));
}
-
- when(replicationEndpoint.getRegionServers())
- .thenReturn(serverNames);
-
+ this.replicationEndpoint.setRegionServers(serverNames);
Review comment:
nit: I guess 'this' is redundant in multiple places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] petersomogyi closed pull request #1103: HBASE-23753 Update
of errorprone generated failures
Posted by GitBox <gi...@apache.org>.
petersomogyi closed pull request #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1103:
HBASE-23753 Update of errorprone generated failures
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#discussion_r372132709
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
##########
@@ -152,12 +153,11 @@ public long getSeqid() {
* priority beyond FIFO, they should override {@link #getPriority()}.
*/
@Override
- public int compareTo(Runnable o) {
- EventHandler eh = (EventHandler)o;
- if(getPriority() != eh.getPriority()) {
- return (getPriority() < eh.getPriority()) ? -1 : 1;
+ public int compareTo(EventHandler o) {
+ if(getPriority() != o.getPriority()) {
Review comment:
nit: include a null check in the beginning for o?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1103:
HBASE-23753 Update of errorprone generated failures
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#discussion_r372131545
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
##########
@@ -18,6 +18,7 @@
*/
package org.apache.hadoop.hbase.executor;
+import java.awt.*;
Review comment:
nit: looks incorrect? Might also run into checkstyle issue with start import.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] petersomogyi commented on issue #1103: HBASE-23753 Update
of errorprone generated failures
Posted by GitBox <gi...@apache.org>.
petersomogyi commented on issue #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#issuecomment-579687858
Closing. This was merged to master and branch-2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1103:
HBASE-23753 Update of errorprone generated failures
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#discussion_r372134839
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
##########
@@ -152,12 +153,11 @@ public long getSeqid() {
* priority beyond FIFO, they should override {@link #getPriority()}.
*/
@Override
- public int compareTo(Runnable o) {
- EventHandler eh = (EventHandler)o;
- if(getPriority() != eh.getPriority()) {
- return (getPriority() < eh.getPriority()) ? -1 : 1;
+ public int compareTo(EventHandler o) {
+ if(getPriority() != o.getPriority()) {
Review comment:
Will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1103: HBASE-23753 Update
of errorprone generated failures
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#issuecomment-579562696
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 6m 57s | branch-2 passed |
| +1 :green_heart: | compile | 1m 45s | branch-2 passed |
| +1 :green_heart: | checkstyle | 2m 9s | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 44s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 20s | branch-2 passed |
| +0 :ok: | spotbugs | 4m 59s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 6m 43s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 25s | the patch passed |
| +1 :green_heart: | compile | 1m 49s | the patch passed |
| +1 :green_heart: | javac | 1m 49s | the patch passed |
| -1 :x: | checkstyle | 1m 38s | hbase-server: The patch generated 4 new + 1 unchanged - 0 fixed = 5 total (was 1) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 54s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 21m 12s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 1m 15s | the patch passed |
| +1 :green_heart: | findbugs | 5m 58s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 17s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 156m 46s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 49s | The patch does not generate ASF License warnings. |
| | | 241m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1103/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1103 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6a29a7fe5386 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1103/out/precommit/personality/provided.sh |
| git revision | branch-2 / 36cdcad43f |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1103/1/artifact/out/diff-checkstyle-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1103/1/testReport/ |
| Max. process+thread count | 5290 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1103/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1103: HBASE-23753 Update of
errorprone generated failures
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#issuecomment-579568299
Merged on cli w/ @bharathv suggestions. Forgot to add signed-off-by for you... @bharathv ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services