[GitHub] [tvm] tqchen commented on pull request #11129: [TIR] Reduced duplication in op.h

[GitBox <gi...@apache.org>]

tqchen commented on PR #11129:
URL: https://github.com/apache/tvm/pull/11129#issuecomment-1109900766

   Thanks @Lunderberg . The particular PR broadens the definition of `const_int` to include broadcasted values. 
   
   It might be useful to think about whether or not that would change the intended use of the original code that depends on those checks.  To be extra careful, it would be helpful to introduce a separate function, `is_const_broadcast` to resolve the new intended checks.
   
   Given it is the inline functions can be called frequently and the typec checking logics themselves are not longer compared to a call into a subfunction, we can keep implementation of is_positive_int as it is. I agree that in the case of broadcast pattern then the new impl would be better for a new function


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org